From: Andrew Morton <akpm@digeo.com>
To: Zach Brown <zab@zabbo.net>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.39 list_head debugging
Date: Sat, 28 Sep 2002 23:12:46 -0700 [thread overview]
Message-ID: <3D9699DE.F7528065@digeo.com> (raw)
In-Reply-To: 20020929015852.K13817@bitchcake.off.net
Zach Brown wrote:
>
> ...
> + BUG_ON(list == NULL);
> + BUG_ON(list->next == NULL);
> + BUG_ON(list->prev == NULL);
> + BUG_ON(list->next->prev != list);
> + BUG_ON(list->prev->next != list);
> + BUG_ON((list->next == list) && (list->prev != list));
> + BUG_ON((list->prev == list) && (list->next != list));
> +
Could we make these just do a printk+dump_stack and continue
on? A BUG is a bit severe.
If you do this, I suggest you add the text "warning" to
the printk. People tend to think that the dump_stack output
is an actual oops, and they get all worried.
next prev parent reply other threads:[~2002-09-29 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 5:58 [PATCH] 2.5.39 list_head debugging Zach Brown
2002-09-29 6:12 ` Andrew Morton [this message]
2002-09-29 6:24 ` Zach Brown
2002-09-29 8:33 ` Ingo Molnar
2002-09-29 14:27 ` Zach Brown
2002-09-29 14:28 ` Martin J. Bligh
2002-09-29 14:30 ` Zach Brown
2002-09-29 17:22 ` Dave Jones
2002-09-29 20:22 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9699DE.F7528065@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox