Re: [PATCH] pcnet32 cable status check

Kent Yoder
2002-10-01T17:29:47Z

Thus Spake Jeff Garzik:
>
>Looks good ;-)

Thanks,

>
>One small thing -- since you appear to test all cases for (lp->mii)
>before calling mod_timer, I don't think you need to test lp->mii inside
>the timer...

Well, the reason I left that in there was so that another person could add
functionality to the watchdog if they wanted on a non-mii enabled card
without having to know that the check would need to be added. If that's not
that big a deal, I can remove it...

>As Felipe mentioned, using the link interrupt instead of a timer is
>preferred -- but my own preference would be to apply your patch with the
>small remove-lp->mii-check fixup, and then investigate the support of
>link interrupts. The reasoning is that, pcnet32 covers a ton of chips,
>and not all may support a link interrupt.
>
> Jeff
>
>
>