From: Jeff Garzik <jgarzik@pobox.com>
To: Kent Yoder <key@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org, tsbogend@alpha.franken.de
Subject: Re: [PATCH] pcnet32 cable status check
Date: Tue, 01 Oct 2002 13:36:01 -0400 [thread overview]
Message-ID: <3D99DD01.9070508@pobox.com> (raw)
In-Reply-To: Pine.LNX.4.44.0210011222520.14661-100000@ennui.austin.ibm.com
Kent Yoder wrote:
> Thus Spake Jeff Garzik:
>
>>Looks good ;-)
>
>
> Thanks,
>
>
>>One small thing -- since you appear to test all cases for (lp->mii)
>>before calling mod_timer, I don't think you need to test lp->mii inside
>>the timer...
>
>
> Well, the reason I left that in there was so that another person could add
> functionality to the watchdog if they wanted on a non-mii enabled card
> without having to know that the check would need to be added. If that's not
> that big a deal, I can remove it...
That's a fair enough argument, patch applied.
next prev parent reply other threads:[~2002-10-01 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 19:31 [PATCH] pcnet32 cable status check Kent Yoder
2002-09-30 20:21 ` Jeff Garzik
2002-09-30 21:48 ` Oops on 2.5.39 was " Kent Yoder
2002-09-30 21:55 ` Jeff Garzik
2002-10-01 16:34 ` Kent Yoder
2002-10-01 16:50 ` Felipe W Damasio
2002-10-01 17:07 ` Jeff Garzik
2002-10-01 17:19 ` Kent Yoder
2002-10-01 17:19 ` Jeff Garzik
2002-10-01 17:30 ` Kent Yoder
2002-10-01 17:36 ` Jeff Garzik [this message]
2002-10-01 19:35 ` Kent Yoder
2002-10-01 17:40 ` Felipe W Damasio
2002-10-07 15:31 ` Kent Yoder
2002-10-22 1:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D99DD01.9070508@pobox.com \
--to=jgarzik@pobox.com \
--cc=key@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox