From: Martin Wirth <Martin.Wirth@dlr.de>
To: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [patch] futex-2.5.40-B5
Date: Wed, 02 Oct 2002 20:14:03 +0200 [thread overview]
Message-ID: <3D9B376B.6060900@dlr.de> (raw)
Ingo,
in your updated futex patch you use get_page/put_page for page pinning.
But for reserved pages, put_page does not decrement the page counter, so
get_page should not be called for such pages. These was a patch included
in 2.5.40 which changed this the call to page_cache_get
(==get_page in current implementation) in get_user_pages to:
if (!PageReserved(page))
get_page(page);
So I think the futex code should do the same.
Martin
next reply other threads:[~2002-10-02 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-02 18:14 Martin Wirth [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-10-05 0:53 [patch] futex-2.5.40-B5 Seth, Rohit
2002-10-05 0:00 Oleg Nesterov
2002-10-05 0:42 ` Linus Torvalds
2002-10-02 12:14 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9B376B.6060900@dlr.de \
--to=martin.wirth@dlr.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox