From: Andrew Morton <akpm@digeo.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Mark Peloquin <peloquin@us.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add safe version of list_for_each_entry() to list.h
Date: Fri, 04 Oct 2002 09:33:34 -0700 [thread overview]
Message-ID: <3D9DC2DE.F6CD0B50@digeo.com> (raw)
In-Reply-To: 20021004170021.F18545@parcelfarce.linux.theplanet.co.uk
Matthew Wilcox wrote:
>
> On Fri, Oct 04, 2002 at 10:48:33AM -0500, Mark Peloquin wrote:
> > list_empty() can be used on check list heads *or*
> > to check if a list element is currently in a list,
> > assuming the coder uses list_del_init(). However,
> > if the coder chooses to use list_del() [which sets
> > the prev and next fields to 0] instead, there is no
> > corresponding function to indicate if that element
> > is currently on a list. This function does that.
>
> That behaviour for list_del is new and, IMNSHO, bogus. There's now _zero_
> gain in using list_del instead of list_del_init. akpm changed it about
> 5 months ago with a comment that says:
>
> "list_head debugging"
>
It doesn't seem to have caught anyone out, so I guess we can
put it back now. I'll do a patch.
next prev parent reply other threads:[~2002-10-04 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-04 15:48 [PATCH] add safe version of list_for_each_entry() to list.h Mark Peloquin
2002-10-04 16:00 ` Matthew Wilcox
2002-10-04 16:33 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-10-04 16:40 Mark Peloquin
2002-10-04 15:05 Matthew Wilcox
2002-10-03 23:42 Mark Peloquin
2002-10-03 23:44 ` Greg KH
2002-10-04 0:25 ` Kevin Corry
2002-10-04 13:58 ` Christoph Hellwig
2002-10-04 13:48 ` Kevin Corry
2002-10-04 13:51 ` Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9DC2DE.F6CD0B50@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peloquin@us.ibm.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox