From: Jeff Garzik <jgarzik@pobox.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] pcibios_* removals for 2.5.40
Date: Fri, 04 Oct 2002 17:34:40 -0400 [thread overview]
Message-ID: <3D9E0970.70903@pobox.com> (raw)
In-Reply-To: 20021004205410.GD8346@kroah.com
Greg KH wrote:
> @@ -1563,13 +1562,11 @@
>
> if (pci_present()) {
an example of pci_present() that can be eliminated, as I described earlier
> for (i = 0; i < NPCI_CHIP_IDS; ++i)
> - for (pci_index = 0;
> - !pcibios_find_device (PCI_VENDOR_ID_NCR,
> - pci_chip_ids[i].pci_device_id, pci_index, &pci_bus,
> - &pci_device_fn);
> - ++pci_index)
> + while ((pdev = pci_find_device (PCI_VENDOR_ID_NCR,
> + pci_chip_ids[i].pci_device_id,
> + pdev)))
> if (!ncr_pci_init (tpnt, BOARD_GENERIC, pci_chip_ids[i].chip,
> - pci_bus, pci_device_fn, /* no options */ 0))
> + pdev->bus->number, pdev->devfn, /* no options */ 0))
can you eliminate the need of ncr_pci_init to have number/devfn args?
next prev parent reply other threads:[~2002-10-04 21:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-03 22:40 [BK PATCH] pcibios_* removals for 2.5.40 Greg KH
2002-10-03 22:40 ` Greg KH
2002-10-03 22:41 ` Greg KH
2002-10-03 22:41 ` Greg KH
2002-10-04 16:33 ` Linus Torvalds
2002-10-04 16:53 ` Alan Cox
2002-10-04 17:30 ` Linus Torvalds
2002-10-04 18:01 ` Greg KH
2002-10-04 16:59 ` Greg KH
2002-10-04 17:28 ` Alan Cox
2002-10-04 18:07 ` Arnaldo Carvalho de Melo
2002-10-04 20:51 ` Greg KH
2002-10-04 20:52 ` Greg KH
2002-10-04 20:53 ` Greg KH
2002-10-04 20:54 ` Greg KH
2002-10-04 21:34 ` Jeff Garzik [this message]
2002-10-04 21:52 ` Greg KH
2002-10-04 21:36 ` Jeff Garzik
2002-10-04 21:40 ` Jeff Garzik
2002-10-04 21:53 ` Greg KH
2002-10-04 22:14 ` Russell King
2002-10-04 18:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D9E0970.70903@pobox.com \
--to=jgarzik@pobox.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox