Re: [Ext2-devel] [RFC] [PATCH 1/4] Add extended attributes to ext2/3

[Andrew Morton <akpm@digeo.com>]

Christoph Hellwig wrote:
> 
> On Tue, Oct 08, 2002 at 02:08:11PM -0400, tytso@mit.edu wrote:
> >
> > This is the first of four patches which add extended attribute support
> > to the ext2 and ext3 filesystems.  It is a port of Andreas Gruenbacher's
> > patches, which have been well tested and in a number of distributions
> > (including RH 8, if I'm not mistaken) already.
> 
> RH backed it out after the second or third beta due to bugginess..
> 
> > This first patch creates a generic interface for registering caches with
> > the VM subsystem so that they can react appropriately to memory
> > pressure.
> 
> I'd suggest Ed Tomlinson's much saner interface that adds a third callbackj
> to kmem_cache_t (similar to the Solaris implementation) instead.
> 
> Doing this outside slab is not a good idea (and XFS currently does
> it too - in it's own code which should be replaced with Ed's one)

Yup, although that's a fairly minor point in this context..

The shrinker callback code is not actually in Linus's kernel
at present.  I'm kind of sitting on it until I've had time
to ponder the dirty great lock which Ed added ;)