Re: [patch] remove BKL from inode_setattr

Steve Lord
2002-10-14T16:45:35Z

On Mon, 2002-10-14 at 11:41, Andrew Morton wrote:
> >
> > XFS deliberately does not take the BKL - anywhere. Our setattr
> > code is doing its own locking. You just added the BKL to a
> > bunch of xfs operations which do not need it. Now, vmtruncate
> > may need it, itself, but if vmtruncate does not, then the xfs
> > callout from vmtruncate certainly does not.
> >
>
> Sorry, but that is standard "bkl migration" methodology. You had it
> before, so you get it after. It is not my role to change XFS locking.

But you did .... my point was, XFS does not use the BKL at all, has
never needed it and never will. The setattr call you added it to
meant you added it to chown, chmod etc. When the BKL was migrated
down below the vfs layer in all those places I deliberately did not
add it to the XFS calls.

>
> Anyway, I don't think these patches are going anywhere.

No problem,

Steve

--

Steve Lord voice: +1-651-683-3511
Principal Engineer, Filesystem Software email: lord@sgi.com