Re: [PATCH] aio updates

Benjamin LaHaise
2002-10-15T19:51:44Z

On Mon, Oct 14, 2002 at 06:17:33PM -0700, John Myers wrote:
> Please apply.
> # fix uninitialized variable causing incorrect timeout
> # add support for IO_CMD_NOOP
> # make sys_io_cancel(), not cancel method, initialize most of returned result
> # minor aio_cancel_all() optimization
> # fix a debug printk

I've applied most of this to my tree, except for the NOOP bits. My
concern is that the way you've implemented NOOP does not allow for all
possible return codes to be passed in due to the error checking the
iocb submit code performs on the inputs. It can also spuriously fail
if the filedescriptor field points to an fd that doesn't exist, which
could be somewhat unexpected (especially if it is initialized to 0 by
default, and therefore would not fail during normal operation where a
program is run with stdin). Got any idea for cleaning those problems
up?

-ben