public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Clark <michael@metaparadigm.com>
To: Simon Roscic <simon.roscic@chello.at>
Cc: Arjan van de Ven <arjanv@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [Kernel 2.5] Qlogic 2x00 driver
Date: Wed, 16 Oct 2002 10:51:11 +0800	[thread overview]
Message-ID: <3DACD41F.2050405@metaparadigm.com> (raw)
In-Reply-To: 200210152153.08603.simon.roscic@chello.at

Version 6.1b5 does appear to be a big improvement from looking
at the code (certainly much more readable than version 4.x end earlier).

Although the method for creating the different modules for
different hardware is pretty ugly.

in qla2300.c

#define ISP2300
[snip]
#include "qla2x00.c"

in qla2200.c

#define ISP2200
[snip]
#include "qla2x00.c"

I'm sure this would have to go before it got it.

~mc

On 10/16/02 03:53, Simon Roscic wrote:
> On Tuesday 15 October 2002 21:31, Arjan van de Ven <arjanv@redhat.com> wrote:
> 
>>Oh so you haven't notices how it buffer-overflows the kernel stack, how
>>it has major stack hog issues, how it keeps the io request lock (and
>>interrupts disabled) for a WEEK ?

This may have been the cause of problems I had running qla driver with
lvm and ext3 - I was getting ooops with what looked like corrupted bufferheads.

This was happening in pretty much all kernels I tried (a variety of
redhat kernels and aa kernels). Removing LVM has solved the problem.
Although i was blaming LVM - maybe it was a buffer overflow in qla driver.

The rh kernel I tried had quite an old version (4.31) of the driver
suffered from problems recovering from LIP resets. The latest 6.x drivers
seem to handle this much better.

~mc


  reply	other threads:[~2002-10-16  2:45 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-15 19:20 [Kernel 2.5] Qlogic 2x00 driver Simon Roscic
2002-10-15 19:31 ` Arjan van de Ven
2002-10-15 19:53   ` Simon Roscic
2002-10-16  2:51     ` Michael Clark [this message]
2002-10-16  3:56       ` GrandMasterLee
2002-10-16  4:30         ` Michael Clark
2002-10-16  4:35           ` J Sloan
2002-10-16  4:43             ` GrandMasterLee
2002-10-16  6:03               ` Michael Clark
2002-10-16  6:31                 ` GrandMasterLee
2002-10-16  6:40                   ` Michael Clark
2002-10-16  6:48                     ` GrandMasterLee
2002-10-16  6:59                       ` Michael Clark
2002-10-16  4:58             ` GrandMasterLee
2002-10-16  5:28             ` Michael Clark
2002-10-16  5:40               ` Andreas Dilger
2002-10-17  1:59                 ` Andrew Vasquez
2002-10-17  2:44                   ` GrandMasterLee
2002-10-17  3:11                     ` Andrew Vasquez
2002-10-17  3:42                       ` GrandMasterLee
2002-10-17  9:40                       ` Michael Clark
2002-10-18  6:45                         ` GrandMasterLee
2002-10-16 16:28       ` Simon Roscic
2002-10-16 16:49         ` Michael Clark
2002-10-17  3:12           ` GrandMasterLee
2002-10-17  3:54             ` Michael Clark
2002-10-17  4:08               ` GrandMasterLee
2002-10-17  5:03                 ` Michael Clark
2002-10-16  5:02 ` GrandMasterLee
2002-10-16 16:38   ` Simon Roscic
2002-10-17  3:08     ` GrandMasterLee
2002-10-17 17:47       ` Simon Roscic
2002-10-18  6:42         ` GrandMasterLee
2002-10-18 15:11           ` Simon Roscic
  -- strict thread matches above, loose matches on Subject: below --
2002-10-19  2:17 rwhron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DACD41F.2050405@metaparadigm.com \
    --to=michael@metaparadigm.com \
    --cc=arjanv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon.roscic@chello.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox