From: Andrew Morton <akpm@digeo.com>
To: David Howells <dhowells@cambridge.redhat.com>
Cc: Rik van Riel <riel@conectiva.com.br>,
David Howells <dhowells@redhat.com>,
Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do_generic_file_read / readahead adjustments
Date: Wed, 16 Oct 2002 11:03:38 -0700 [thread overview]
Message-ID: <3DADA9FA.1D578A27@digeo.com> (raw)
In-Reply-To: 30901.1034790945@warthog.cambridge.redhat.com
David Howells wrote:
>
> This patch is the alternative: make a function (do_generic_mapping_read())
> that I can pass an inode or an address_space to, and make
> do_generic_file_read() call that. This allows me to make use of readahead
> semantics without having to reinvent them for myself.
>
OK. The current readahead and mpage code is really designed just
for ext2-style filesystems. It was always expected that it would
have to grow as more sophisticated filesytems put demands upon it.
Your change is a perfectly sensible generalisation. The reiserfs
team have been making noises about lower-level readahead hooks as well,
and I think your patch largely addresses those. I shall ping them.
next prev parent reply other threads:[~2002-10-16 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-16 15:29 [PATCH] do_generic_file_read / readahead adjustments David Howells
2002-10-16 16:19 ` Andrew Morton
2002-10-16 16:36 ` Rik van Riel
2002-10-16 17:55 ` David Howells
2002-10-16 18:03 ` Andrew Morton [this message]
2002-10-16 18:08 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2002-10-16 18:06 dhowells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DADA9FA.1D578A27@digeo.com \
--to=akpm@digeo.com \
--cc=dhowells@cambridge.redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox