From: Jeff Garzik <jgarzik@pobox.com>
To: Andrey Panin <pazke@orbita1.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
Date: Thu, 17 Oct 2002 10:21:12 -0400 [thread overview]
Message-ID: <3DAEC758.5040209@pobox.com> (raw)
In-Reply-To: 20021017070332.GB304@pazke.ipt
Andrey Panin wrote:
> diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104x.c linux/drivers/net/tulip/de2104x.c
> --- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002
> +++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002
> @@ -2216,7 +2216,7 @@
> .name = DRV_NAME,
> .id_table = de_pci_tbl,
> .probe = de_init_one,
> - .remove = de_remove_one,
> + .remove = __devexit_p(de_remove_one),
> #ifdef CONFIG_PM
> .suspend = de_suspend,
> .resume = de_resume,
alas, it is incorrect, as no one hotplugs this hardware.
Jeff
next prev parent reply other threads:[~2002-10-17 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 7:03 [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43 Andrey Panin
2002-10-17 14:21 ` Jeff Garzik [this message]
2002-10-18 5:46 ` Andrey Panin
-- strict thread matches above, loose matches on Subject: below --
2002-10-17 17:14 Adam J. Richter
2002-10-17 17:20 ` Jeff Garzik
2002-10-18 19:41 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DAEC758.5040209@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@orbita1.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox