* Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
@ 2002-10-17 17:14 Adam J. Richter
2002-10-17 17:20 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Adam J. Richter @ 2002-10-17 17:14 UTC (permalink / raw)
To: jgarzik, linux-kernel
Jeff Garzik wrote:
>Andrey Panin wrote:
>> diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104x.c \
>> linux/drivers/net/tulip/de2104x.c
>> --- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002
>> +++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002
>> @@ -2216,7 +2216,7 @@
>> .name = DRV_NAME,
>> .id_table = de_pci_tbl,
>> .probe = de_init_one,
>> - .remove = de_remove_one,
>> + .remove = __devexit_p(de_remove_one),
>> #ifdef CONFIG_PM
>> .suspend = de_suspend,
>> .resume = de_resume,
>
>
>alas, it is incorrect, as no one hotplugs this hardware.
I believe that there are motherboards that use a chipset from
Compaq that allows hot plugging and unplugging of ordinary PCI cards,
supported by drivers in linux-2.5.43/drivers/hotplug/cpq*.[ch]. At a
trade show, I saw a demo of a motherboard with such a capability (not
running Linux, but I think from Compaq).
So, I believe that all ordinary PCI cards (as opposed to
devices soldered onto motherboards, for example) are now hot plug
capable, although their Linux drivers may not yet be.
Do I misunderstand the situation?
As a side note, I also either do not agree or somehow
misunderstand Jeff Garzik's opposition to devexit_p in non-hotplug
drivers, but that issue will irrelevant in the case of de2104.c if it
is indeed possible for all ordinary PCI form factor cards to be
deployed with the hot plug motherboard chipset that I described.
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
2002-10-17 17:14 [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43 Adam J. Richter
@ 2002-10-17 17:20 ` Jeff Garzik
2002-10-18 19:41 ` Bill Davidsen
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2002-10-17 17:20 UTC (permalink / raw)
To: Adam J. Richter; +Cc: linux-kernel
Adam J. Richter wrote:
> I believe that there are motherboards that use a chipset from
> Compaq that allows hot plugging and unplugging of ordinary PCI cards,
> supported by drivers in linux-2.5.43/drivers/hotplug/cpq*.[ch]. At a
> trade show, I saw a demo of a motherboard with such a capability (not
> running Linux, but I think from Compaq).
You are correct that all PCI cards are now hotpluggable.
My position is that _my_ driver will not be converted to be hotpluggable
until someone actually does so. Until such a time, I prefer the space
savings that keeping it non-hotplug-able provides.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
2002-10-17 17:20 ` Jeff Garzik
@ 2002-10-18 19:41 ` Bill Davidsen
0 siblings, 0 replies; 6+ messages in thread
From: Bill Davidsen @ 2002-10-18 19:41 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Adam J. Richter, linux-kernel
On Thu, 17 Oct 2002, Jeff Garzik wrote:
> Adam J. Richter wrote:
> > I believe that there are motherboards that use a chipset from
> > Compaq that allows hot plugging and unplugging of ordinary PCI cards,
> > supported by drivers in linux-2.5.43/drivers/hotplug/cpq*.[ch]. At a
> > trade show, I saw a demo of a motherboard with such a capability (not
> > running Linux, but I think from Compaq).
>
>
> You are correct that all PCI cards are now hotpluggable.
>
> My position is that _my_ driver will not be converted to be hotpluggable
> until someone actually does so. Until such a time, I prefer the space
> savings that keeping it non-hotplug-able provides.
If I read the original post correctly, you save a LOT of space, becasue
the driver won't link without the patch. Sorry if I misread that, and it's
desirable to avoid such a dependency, but if it's hack or forget, expect
hack.
--
bill davidsen <davidsen@tmr.com>
CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
@ 2002-10-17 7:03 Andrey Panin
2002-10-17 14:21 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Andrey Panin @ 2002-10-17 7:03 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 173 bytes --]
IMHO subject and patch are self explainning :)
--
Andrey Panin | Embedded systems software developer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net
[-- Attachment #1.2: patch-de2104x-devexit --]
[-- Type: text/plain, Size: 473 bytes --]
diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104x.c linux/drivers/net/tulip/de2104x.c
--- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002
+++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002
@@ -2216,7 +2216,7 @@
.name = DRV_NAME,
.id_table = de_pci_tbl,
.probe = de_init_one,
- .remove = de_remove_one,
+ .remove = __devexit_p(de_remove_one),
#ifdef CONFIG_PM
.suspend = de_suspend,
.resume = de_resume,
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
2002-10-17 7:03 Andrey Panin
@ 2002-10-17 14:21 ` Jeff Garzik
2002-10-18 5:46 ` Andrey Panin
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2002-10-17 14:21 UTC (permalink / raw)
To: Andrey Panin; +Cc: linux-kernel
Andrey Panin wrote:
> diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104x.c linux/drivers/net/tulip/de2104x.c
> --- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002
> +++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002
> @@ -2216,7 +2216,7 @@
> .name = DRV_NAME,
> .id_table = de_pci_tbl,
> .probe = de_init_one,
> - .remove = de_remove_one,
> + .remove = __devexit_p(de_remove_one),
> #ifdef CONFIG_PM
> .suspend = de_suspend,
> .resume = de_resume,
alas, it is incorrect, as no one hotplugs this hardware.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
2002-10-17 14:21 ` Jeff Garzik
@ 2002-10-18 5:46 ` Andrey Panin
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Panin @ 2002-10-18 5:46 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Thu, Oct 17, 2002 at 10:21:12AM -0400, Jeff Garzik wrote:
> Andrey Panin wrote:
> >diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104xc
> >linux/drivers/net/tulip/de2104x.c
> >--- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002
> >+++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002
> >@@ -2216,7 +2216,7 @@
> > .name = DRV_NAME,
> > .id_table = de_pci_tbl,
> > .probe = de_init_one,
> >- .remove = de_remove_one,
> >+ .remove = __devexit_p(de_remove_one),
> > #ifdef CONFIG_PM
> > .suspend = de_suspend,
> > .resume = de_resume,
>
>
> alas, it is incorrect, as no one hotplugs this hardware.
This patch is not about hotplugging, absence of __devexi_p() makes impossible
to link this driver in kernel.
--
Andrey Panin | Embedded systems software developer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-10-18 19:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-17 17:14 [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43 Adam J. Richter
2002-10-17 17:20 ` Jeff Garzik
2002-10-18 19:41 ` Bill Davidsen
-- strict thread matches above, loose matches on Subject: below --
2002-10-17 7:03 Andrey Panin
2002-10-17 14:21 ` Jeff Garzik
2002-10-18 5:46 ` Andrey Panin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox