From: Andrew Morton <akpm@digeo.com>
To: conman@kolivas.net
Cc: Rik van Riel <riel@conectiva.com.br>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: Pathological case identified from contest
Date: Sat, 19 Oct 2002 20:05:44 -0700 [thread overview]
Message-ID: <3DB21D88.2E845F02@digeo.com> (raw)
In-Reply-To: 200210201259.34935.conman@kolivas.net
Con Kolivas wrote:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Thu, 17 Oct 2002 05:35 pm, you wrote:
> > Con Kolivas wrote:
> > > ...
> > > Well this has become more common with 2.5.43-mm2. I had to abort the
> > > process_load run 3 times when benchmarking it. Going back to other
> > > kernels and trying them it didnt happen so I dont think its my hardware
> > > failing or something like that.
> >
> > No, it's a bug in either the pipe code or the CPU scheduler I'd say.
> >
> > You could try backing out to the 2.5.40 pipe implementation; not sure if
> > that would tell us much though.
>
> I massaged the patch a little for it to apply and it _is_ the offending code.
> Backing out the pipe changes fixed the problem. I was unable to reproduce the
> holdup I was seeing with process_load even at higher data sizes. Now what?
>
Try Manfred's pipe fix I guess?
--- 2.5/fs/pipe.c Sat Oct 19 11:40:14 2002
+++ build-2.5/fs/pipe.c Sat Oct 19 19:44:04 2002
@@ -109,7 +109,7 @@
break;
}
if (do_wakeup) {
- wake_up_interruptible(PIPE_WAIT(*inode));
+ wake_up_interruptible_sync(PIPE_WAIT(*inode));
kill_fasync(PIPE_FASYNC_WRITERS(*inode), SIGIO, POLL_OUT);
}
pipe_wait(inode);
@@ -117,7 +117,7 @@
up(PIPE_SEM(*inode));
/* Signal writers asynchronously that there is more room. */
if (do_wakeup) {
- wake_up_interruptible_sync(PIPE_WAIT(*inode));
+ wake_up_interruptible(PIPE_WAIT(*inode));
kill_fasync(PIPE_FASYNC_WRITERS(*inode), SIGIO, POLL_OUT);
}
if (ret > 0)
next prev parent reply other threads:[~2002-10-20 2:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 2:13 Pathological case identified from contest Con Kolivas
2002-10-17 2:49 ` Andrew Morton
2002-10-17 4:26 ` Con Kolivas
2002-10-17 7:16 ` Con Kolivas
2002-10-17 7:35 ` Andrew Morton
2002-10-17 17:15 ` Rik van Riel
2002-10-20 2:59 ` Con Kolivas
2002-10-20 3:05 ` Andrew Morton [this message]
2002-10-20 6:27 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DB21D88.2E845F02@digeo.com \
--to=akpm@digeo.com \
--cc=conman@kolivas.net \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox