From: Osamu Tomita <tomita@cinet.co.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)
Date: Thu, 24 Oct 2002 00:35:25 +0900 [thread overview]
Message-ID: <3DB6C1BD.41DC80AC@cinet.co.jp> (raw)
In-Reply-To: s5hznt51ksm.wl@alsa2.suse.de
Thanks for comments.
Takashi Iwai wrote:
> At Sat, 19 Oct 2002 01:56:53 +0900,
> Osamu Tomita wrote:
> >
> > This is part 23/26 of patchset for add support NEC PC-9800 architecture,
> > against 2.5.43.
> >
> > Summary:
> > ALSA sound driver related modules.
> > - add feature to support CS4231+OPL3 (not PNP)
>
> Are you sure that it's really CS4231?
> If it's a higher model, such as cs4232, cs4235 or cs4236, FM OPL3 is
> already supported (although additional codes to opl3 module are
> necessary for PC9800).
Your comment is reasonable. Some card has CS4232. But CS4232 is used
as CS4231. I guess there is some hardwired circuit. And some card has
CS4231. CS4231 driver works fine for ether chip on PC-9800.
So I choose CS4231 driver for PC-9800.
> > - add hardware specific initialization.
>
> The MPU401 hack looks odd.
> I'd propose to split a PC9800 specific driver up, rather than
> including bunch of ifdefs...
I see. I'll split MPU401 driver.
Regards
Osamu Tomita
next prev parent reply other threads:[~2002-10-23 15:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-18 16:56 [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa) Osamu Tomita
2002-10-23 11:01 ` Takashi Iwai
2002-10-23 15:35 ` Osamu Tomita [this message]
2002-10-23 15:46 ` Takashi Iwai
2002-10-23 16:12 ` Osamu Tomita
2002-10-23 16:29 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2002-10-25 2:12 Osamu Tomita
2002-10-25 2:47 Osamu Tomita
2002-10-25 10:10 ` Takashi Iwai
2002-10-26 2:54 Osamu Tomita
2002-10-28 17:57 ` Takashi Iwai
2002-10-29 10:08 ` Takashi Iwai
2002-10-29 17:43 ` Osamu Tomita
2002-10-30 17:52 ` Takashi Iwai
2002-11-01 13:02 ` Osamu Tomita
2002-11-01 13:44 ` Takashi Iwai
2002-11-02 2:44 ` Osamu Tomita
2002-11-04 10:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DB6C1BD.41DC80AC@cinet.co.jp \
--to=tomita@cinet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).