* [trivial] module.c double init?
@ 2002-10-24 3:53 Randy.Dunlap
0 siblings, 0 replies; only message in thread
From: Randy.Dunlap @ 2002-10-24 3:53 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
in 2.5.44: kernel/module.c, function s_start(), there is:
loff_t n = *pos;
and then same "n = *pos" is done in the for-loop initializer.
It's just a thinko, right? or am I missing something?
Patch attached (to 2.5.44).
~Randy
[-- Attachment #2: module-dblinit-2544.patch --]
[-- Type: text/plain, Size: 358 bytes --]
--- ./kernel/module.c.fixit Fri Oct 18 21:01:17 2002
+++ ./kernel/module.c Wed Oct 23 19:54:10 2002
@@ -1165,7 +1165,7 @@
if (!p)
return ERR_PTR(-ENOMEM);
lock_kernel();
- for (v = module_list, n = *pos; v; n -= v->nsyms, v = v->next) {
+ for (v = module_list; v; n -= v->nsyms, v = v->next) {
if (n < v->nsyms) {
p->mod = v;
p->index = n;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-10-24 3:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-24 3:53 [trivial] module.c double init? Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).