* [RFC] generic_file_direct_IO() argument changes for AIO
@ 2002-10-29 18:19 Badari Pulavarty
2002-10-29 18:58 ` Andrew Morton
2002-10-29 19:15 ` Chuck Lever
0 siblings, 2 replies; 4+ messages in thread
From: Badari Pulavarty @ 2002-10-29 18:19 UTC (permalink / raw)
To: linux-aio, lkml; +Cc: cel, akpm, Badari Pulavarty
Hi,
Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
to generic_file_direct_IO() and all direct_IO() ops.
generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
loff_t offset, unsigned long nr_segs)
Instead of adding a new argument, I propose replace
"struct file *file" argument with "struct kiocb *iocb"
One can get "filp" from iocb->ki_filp.
Any objections ?
Thanks,
Badari
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC] generic_file_direct_IO() argument changes for AIO
2002-10-29 18:19 [RFC] generic_file_direct_IO() argument changes for AIO Badari Pulavarty
@ 2002-10-29 18:58 ` Andrew Morton
2002-10-29 19:15 ` Chuck Lever
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2002-10-29 18:58 UTC (permalink / raw)
To: Badari Pulavarty; +Cc: linux-aio, lkml, cel
Badari Pulavarty wrote:
>
> Hi,
>
> Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
> to generic_file_direct_IO() and all direct_IO() ops.
>
> generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
> loff_t offset, unsigned long nr_segs)
>
> Instead of adding a new argument, I propose replace
>
> "struct file *file" argument with "struct kiocb *iocb"
>
> One can get "filp" from iocb->ki_filp.
>
> Any objections ?
>
OK by me.
BTW, while you're poking around in there could you please rename
generic_direct_IO() to blockdev_direct_IO() and move
generic_file_direct_IO() back into filemap.c?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC] generic_file_direct_IO() argument changes for AIO
2002-10-29 18:19 [RFC] generic_file_direct_IO() argument changes for AIO Badari Pulavarty
2002-10-29 18:58 ` Andrew Morton
@ 2002-10-29 19:15 ` Chuck Lever
2002-10-29 19:28 ` Badari Pulavarty
1 sibling, 1 reply; 4+ messages in thread
From: Chuck Lever @ 2002-10-29 19:15 UTC (permalink / raw)
To: Badari Pulavarty; +Cc: linux-aio, lkml, akpm
On Tue, 29 Oct 2002, Badari Pulavarty wrote:
> Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
> to generic_file_direct_IO() and all direct_IO() ops.
>
> generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
> loff_t offset, unsigned long nr_segs)
>
> Instead of adding a new argument, I propose replace
>
> "struct file *file" argument with "struct kiocb *iocb"
>
> One can get "filp" from iocb->ki_filp.
>
> Any objections ?
here's a naive objection. is there any preallocated data structure
associated with a kiocb other than the struct itself? if there is, that
will have some scalability impact for applications like Oracle that like
to create a very large database by opening thousands of files.
- Chuck Lever
--
corporate: <cel at netapp dot com>
personal: <chucklever at bigfoot dot com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC] generic_file_direct_IO() argument changes for AIO
2002-10-29 19:15 ` Chuck Lever
@ 2002-10-29 19:28 ` Badari Pulavarty
0 siblings, 0 replies; 4+ messages in thread
From: Badari Pulavarty @ 2002-10-29 19:28 UTC (permalink / raw)
To: Chuck Lever; +Cc: Badari Pulavarty, linux-aio, lkml, akpm
>
> On Tue, 29 Oct 2002, Badari Pulavarty wrote:
>
> > Inorder to support AIO for raw/O_DIRECT, I need to add "struct kiocb *"
> > to generic_file_direct_IO() and all direct_IO() ops.
> >
> > generic_file_direct_IO(int rw, struct file *file, const struct iovec *iov,
> > loff_t offset, unsigned long nr_segs)
> >
> > Instead of adding a new argument, I propose replace
> >
> > "struct file *file" argument with "struct kiocb *iocb"
> >
> > One can get "filp" from iocb->ki_filp.
> >
> > Any objections ?
>
> here's a naive objection. is there any preallocated data structure
> associated with a kiocb other than the struct itself? if there is, that
> will have some scalability impact for applications like Oracle that like
> to create a very large database by opening thousands of files.
>
> - Chuck Lever
If the application is not using Async IO, "kiocb" structure comes
from stack. Other than that, there are no preallocated strcutures
associated with kiocb.
- Badari
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-10-29 19:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-29 18:19 [RFC] generic_file_direct_IO() argument changes for AIO Badari Pulavarty
2002-10-29 18:58 ` Andrew Morton
2002-10-29 19:15 ` Chuck Lever
2002-10-29 19:28 ` Badari Pulavarty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox