Re: [PATCH] Updated sys_epoll now with man pages

bert hubert
2002-10-29T10:58:31Z

On Mon, Oct 28, 2002 at 09:09:56PM -0800, Andrew Morton wrote:

> when I took a 15-minute look at this code last week I found several
> bugs, some of which were grave. It's a terrible thing to say, but

Are there still unresolved bugs?

> epoll seems to be a good and desirable thing. To move forward I
> believe we need to get this code reviewed, and documented.

Davide's code explanation looks nice - do you think it sufficient?

> I can do that if you like; it will take me several weeks to get onto
> it. But until that is completed I would oppose inclusion of this
> code.

This sounds real harsh as this means that it does not, in fact, go in. I'm
no guru but the code in question looks sane and reasonable. The state of the
kernel right now is such that I would really advocate this going in, I'm
sure we can get commitment to vet this code - which is all the easier
because it is going to see more use.

I'll be releasing a version of mtasker (http://ds9a.nl/mtasker) later today
which uses epoll which I'm going to take into production.

Regards,

bert

--
http://www.PowerDNS.com Versatile DNS Software & Services
http://lartc.org Linux Advanced Routing & Traffic Control HOWTO