From: Andrew Morton <akpm@digeo.com>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
William Lee Irwin III <wli@holomorphy.com>
Subject: Re: rbtree scores (was Re: [patch] deadline-ioscheduler rb-tree sort)
Date: Fri, 01 Nov 2002 11:34:03 -0800 [thread overview]
Message-ID: <3DC2D72B.B4D5707E@digeo.com> (raw)
In-Reply-To: 20021101113401.GE8428@suse.de
Jens Axboe wrote:
>
> As expected, the stock version O(N) insertion scan really hurts. Even
> with 128 requests per list, rbtree version is far superior. Once bigger
> lists are used, there's just no comparison whatsoever.
>
Jens, the tree just makes sense.
Remember that we added the blk_grow_request_list() thing to 2.4 for
the Dolphin SCI and other high-end hardware. High throughput, long
request queue, uh-oh. Probably they're not using the stock merge/insert
engine, but I bet someone will want to (Hi, Bill).
And we do know that for some classes of workloads, a larger request
queue is worth a 10x boost in throughput.
The length of the request queue is really a very important VM and
block parameter. Varying it will have much less impact on the VM than
it used to, but it is still there...
When we get on to making the block tunables tunable, request queue
length should be there, and we will be needing that tree.
Have I convinced you yet?
next prev parent reply other threads:[~2002-11-01 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-31 13:43 [patch] deadline-ioscheduler rb-tree sort Jens Axboe
2002-11-01 11:34 ` rbtree scores (was Re: [patch] deadline-ioscheduler rb-tree sort) Jens Axboe
2002-11-01 19:34 ` Andrew Morton [this message]
2002-11-01 20:55 ` Jamie Lokier
2002-11-02 8:59 ` Jens Axboe
2002-11-02 20:22 ` Jamie Lokier
2002-11-02 8:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DC2D72B.B4D5707E@digeo.com \
--to=akpm@digeo.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox