public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kai Engert <kai.engert@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: james@cobaltmountain.com, alan@redhat.com
Subject: Regression in 2.4.20 radeonfb.c
Date: Sun, 03 Nov 2002 15:31:22 +0100	[thread overview]
Message-ID: <3DC5333A.3090808@gmx.de> (raw)

In 2.4.19-rc3-ac2, Alan Cox / James Mayer added a modeline entry to 
modedb.c that enables a 1280x600 console screen on Vaio C1M* devices. 
The patch works fine for me in 2.4.19.

In 2.4.20-pre* kernels, it does no longer work for me, the console 
remains at the default setting.

I identified the hunk below to be the culprit. That check was removed in 
2.4.20-* kernels. When I revert the hunk below, adding back the null 
check, my system again switches to full screen console mode.

I propose to revert the hunk for 2.4.20.
Tested with 2.4.20-rc1.

Thanks,
Kai

(Please CC me on replys)


diff -ru 2419/drivers/video/radeonfb.c 2420/drivers/video/radeonfb.c
--- 2419/drivers/video/radeonfb.c       Sun Nov  3 14:44:07 2002
+++ 2420/drivers/video/radeonfb.c       Sun Nov  3 13:48:47 2002
@@ -877,14 +871,6 @@
         /* mem size is bits [28:0], mask off the rest */
         rinfo->video_ram = tmp & CONFIG_MEMSIZE_MASK;

-       /* According to XFree86 4.2.0, some production M6's return 0
-          for 8MB. */
-       if (rinfo->video_ram == 0 &&
-           (pdev->device == PCI_DEVICE_ID_RADEON_LY ||
-            pdev->device == PCI_DEVICE_ID_RADEON_LZ)) {
-           rinfo->video_ram = 8192 * 1024;
-         }
-
         /* ram type */
         tmp = INREG(MEM_SDRAM_MODE_REG);
         switch ((MEM_CFG_TYPE & tmp) >> 30) {



             reply	other threads:[~2002-11-03 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-03 14:31 Kai Engert [this message]
2002-11-03 14:48 ` Regression in 2.4.20 radeonfb.c Adrian Bunk
2002-11-03 15:23   ` James Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DC5333A.3090808@gmx.de \
    --to=kai.engert@gmx.de \
    --cc=alan@redhat.com \
    --cc=james@cobaltmountain.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox