public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-aio@kvack.org, lkml <linux-kernel@vger.kernel.org>,
	bcrl@redhat.com
Subject: Re: [PATCH 2/2] 2.5.46 AIO support for raw/O_DIRECT
Date: Tue, 05 Nov 2002 17:17:32 -0800	[thread overview]
Message-ID: <3DC86DAC.4EBB59C8@digeo.com> (raw)
In-Reply-To: 200211060103.gA613a321256@eng2.beaverton.ibm.com

Badari Pulavarty wrote:
> 
> Hi,
> 
> This is (part 2/2) 2.5.46 patch to support AIO for raw/O_DIRECT.
> 
> This patch adds AIO support for DIO code path. This patch also
> has a work around for calling set_page_dirty() from interrupt
> context problem.
> 
> Andrew, could you please check to see if I did "set_page_dirty()"
> hack (you suggested) correctly (in the right place) ?
> 

Looks like it.  It's such a hack, I want to hide ;)

Sigh.  I think I'd prefer to just go and make ->page_lock
and ->private_lock irq-safe.

Or not proceed with this patch at all.  If this is to be the
only code which wishes to perform page list motion at interrupt
time, perhaps it's not justifiable?

I really don't have a feeling for how valuable this is, nor
do I know whether there will be other code which wants to
perform page list manipulation at interrupt time.

In fact I also don't know where the whole AIO thing sits at
present.  Is it all done and finished?  Is there more to come,
and if so, what??

  reply	other threads:[~2002-11-06  1:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-06  1:03 [PATCH 2/2] 2.5.46 AIO support for raw/O_DIRECT Badari Pulavarty
2002-11-06  1:17 ` Andrew Morton [this message]
2002-11-06  7:05   ` Benjamin LaHaise
2002-11-06  7:23     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DC86DAC.4EBB59C8@digeo.com \
    --to=akpm@digeo.com \
    --cc=bcrl@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox