Re: [PATCH] sysfs stuff for eisa bus [1/3]

[Jeff Garzik <jgarzik@pobox.com>]

Andries Brouwer wrote:

> On Sun, Nov 10, 2002 at 10:55:15PM +0100, Marc Zyngier wrote:
>
>
> >First patch is contains the infrastructure and the naming database :
>
>
> Is the database not very incomplete?
> What use is a very long and very incomplete list?
> Just like for USB and PCI it might be more reasonable to
> have such a list with IDs on a website instead of in the
> kernel source?



While I do agree your criticisms are fair, I think they apply to the 
overall system and not specifically to Marc's EISA code.  I've been 
hoping that someone would do the infrastructure work necessary to 
support drivers in a pci_driver-like fashion, and I'm glad Marc has done 
this.

That said, tangent to your argument, I would also like to separate the 
PCI ids from the C source code -- but still compile the PCI id table 
into the .o file by default.  There are certainly other uses for the PCI 
id table, but I think sufficient additional flexibility is afforded 
simply by the movement of the id table at source code level.

	Jeff