From: Andrew Morton <akpm@digeo.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] swap writepages swizzled
Date: Mon, 11 Nov 2002 11:14:57 -0800 [thread overview]
Message-ID: <3DD001B1.F5F2CC9D@digeo.com> (raw)
In-Reply-To: Pine.LNX.4.44.0211111826590.1278-100000@localhost.localdomain
Hugh Dickins wrote:
>
> ...
> optional patch
> to try_to_free_buffers, once upon a time swap came that way,
> happily ever after it doesn't, so the test seems misleading.
>
Alas, swapcache pages can still have buffers attached.
It's pretty rare. Suppose an application has paged in a page from
an ext3 file. It is sleeping on the completion of the read. Now,
the file is ftruncated. Pagetables are torn down and truncate_inode_pages
tries to throw away the pagecache. But the particular page which is
being faulted in has an elevated refcount, so it is not succesfully
freed by truncate. It _is_ removed from pagecache.
The page is instantiated in the faulter's pagetables as an anonymous
page just floating out there somewhere.
It doesn't have its buffers removed either, because it was attached
to an ext3 transaction at the time of the truncate, and try_to_release_page()
failed.
We end up with an anonymous, swappable page which has buffers.
So we need to keep that test.
prev parent reply other threads:[~2002-11-11 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-11 19:02 [PATCH] swap writepages swizzled Hugh Dickins
2002-11-11 19:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD001B1.F5F2CC9D@digeo.com \
--to=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox