Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)

[george anzinger <george@mvista.com>]

"Randy.Dunlap" wrote:
> 
> Hi George,
> 
> I have a couple of small comments on the latest POSIX interface
> patch (take 10 -- NOT HIGH RES).
> 
> 1.  arch/i386/kernel/entry.S uses nr_syscalls and the patch
> removes NR_syscalls from include/asm-i386/sys.h, but
> user-mode-linux needs/uses NR_syscalls.  However, I see why you
> removed it from sys.h:  it's basically a dead file.
> And it looks like include/linux/sys.h shouldn't have that
> #define in it (should be per arch).

The best place for this define, if it is needed at all, is
in unistd.h.  It seems really silly to have to modify so
many files to add a system call.  If it were not so late in
the game, I would offer up a single file system call thing,
but after 260 calls, well, maybe I will even so, but AFTER
the freeze since it will not add any new features.
> 
> 2.  again in arch/i386/kernel/entry.S:  the added syscall number
> /*comments*/ are off by 1.

Oops!  Just a comment though :)
 

-- 
George Anzinger   george@mvista.com
High-res-timers: 
http://sourceforge.net/projects/high-res-timers/
Preemption patch:
http://www.kernel.org/pub/linux/kernel/people/rml