Re: [0/4] NUMA-Q: remove PCI bus number mangling

Greg KH
2002-11-13T00:19:00Z

On Tue, Nov 12, 2002 at 04:12:46PM -0800, William Lee Irwin III wrote:
> On Tue, Nov 12, 2002 at 03:58:24PM -0800, William Lee Irwin III wrote:
> >> Okay, an attempt to remedy this world-breaking braindamage with the
> >> fewest lines of code:
> >> This alters PCI bus number "clash" detection to compare ->sysdata in
> >> addition to the numbers. The bus number is not a unique identifier.
>
> On Tue, Nov 12, 2002 at 04:04:35PM -0800, Greg KH wrote:
> > Um, why not?
> > And what would /sys/bus/pci/devices look like if you allow the same
> > identifiers for different devices? :)
> > thanks,
> > greg k-h
>
> (1) incorrect semantics:
> multiple domains/segments exist, and the bus number is not
> qualified with such
> (2) insufficient cardinality:
> even in the presence of remapping schemes the bus space is limited
> to less than the number of buses requiring unique identifiers

Ok, then also please fix up drivers/pci/probe.c::pci_setup_device() to
set a unique slot_name up for the pci_dev, if you have multiple
domains/segments.

thanks,

greg k-h