From: Luben Tuikov <luben@splentec.com>
To: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lockup
Date: Wed, 13 Nov 2002 16:00:44 -0500 [thread overview]
Message-ID: <3DD2BD7C.ABCA9350@splentec.com> (raw)
A few of our IDE hds were generating those errors.
The first one locks up the 3w-xxxx driver (into an inf. loop)
when the error register = 0x11; this also resulted sometimes
in kernel lockup, also when doing raidstop...
The second one (0x51 move) is for completely broken
sectors/medium -- this makes SCSI core figure this one out
quickly and do the appropriate action, rather than retry
the command several times + timeout, of course without
success.
For the status byte, we're more generous (actually only interested
in the error bit); if found, good, else the effect is the same.
--
Luben
--- linux-2.5.47/drivers/scsi/3w-xxxx.h Sun Nov 10 22:28:06 2002
+++ linux/drivers/scsi/3w-xxxx.h Wed Nov 13 15:07:28 2002
@@ -108,7 +108,9 @@
{0x01, 0x03, 0x13, 0x00}, // Address mark not found Address mark not found for data field
{0x04, 0x0b, 0x00, 0x00}, // Aborted command Aborted command
{0x10, 0x0b, 0x14, 0x00}, // ID not found Recorded entity not found
+ {0x11, 0x0b, 0x12, 0x00}, // Address Mark Not Found Address Mark Not Found For ID Field
{0x40, 0x03, 0x11, 0x00}, // Uncorrectable ECC error Unrecovered read error
+ {0x51, 0x03, 0x31, 0x00}, // Uncorrectable Data Error Medium Format Corrupted
{0x61, 0x04, 0x00, 0x00}, // Device fault Hardware error
{0x84, 0x0b, 0x47, 0x00}, // Data CRC error SCSI parity error
{0xd0, 0x0b, 0x00, 0x00}, // Device busy Aborted command
@@ -118,7 +120,6 @@
// 3ware Error SCSI Error
{0x09, 0x0b, 0x00, 0x00}, // Unrecovered disk error Aborted command
{0x37, 0x0b, 0x04, 0x00}, // Unit offline Logical unit not ready
- {0x51, 0x0b, 0x00, 0x00} // Unspecified Aborted command
};
/* Control register bit definitions */
--- linux-2.5.47/drivers/scsi/3w-xxxx.c Sun Nov 10 22:28:30 2002
+++ linux/drivers/scsi/3w-xxxx.c Wed Nov 13 15:07:28 2002
@@ -716,7 +716,7 @@
/* Attempt to return intelligent sense information */
if (fill_sense) {
- if ((command->status == 0xc7) || (command->status == 0xcb)) {
+ if (command->status & 0xC1) {
for (i=0;i<(sizeof(tw_sense_table)/sizeof(tw_sense_table[0]));i++) {
if (command->flags == tw_sense_table[i][0]) {
next reply other threads:[~2002-11-13 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-13 21:00 Luben Tuikov [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-11-13 21:57 [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lo ckup Adam Radford
2002-11-13 22:24 ` [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lockup Luben Tuikov
2002-11-13 22:32 [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lo ckup Adam Radford
2002-11-13 23:53 ` [PATCH] 3w-xxxx: additional ata->sense codes, avoid driver lockup Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD2BD7C.ABCA9350@splentec.com \
--to=luben@splentec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox