public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Steinmetz <ast@domdv.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: lkml <linux-kernel@vger.kernel.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Linux 2.4.20-rc2 in2000.c and t128.c build fixes (resend)
Date: Fri, 15 Nov 2002 20:19:11 +0100	[thread overview]
Message-ID: <3DD548AF.2000204@domdv.de> (raw)
In-Reply-To: Pine.LNX.4.44L.0211151309400.11268-100000@freak.distro.conectiva

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

Marcelo,
it seems the gcc 3.2 build fixes for in2000.c and t128.c got lost.

Please see:

http://marc.theaimsgroup.com/?l=linux-kernel&m=103641735125372&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=103641959127368&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=103641876226674&w=2

Example error without the patch:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.20rc2/include -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -mcpu=i686 
-march=i686 -falign-loops -falign-jumps -falign-functions   -nostdinc 
-iwithprefix include -DKBUILD_BASENAME=in2000  -c -o in2000.o in2000.c
in2000.c:1919: base_tab causes a section type conflict
in2000.c:1926: int_tab causes a section type conflict
make[3]: *** [in2000.o] Error 1

The attached and combined patch is modified to reflect Alan's comment as 
referenced above.
-- 
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH

[-- Attachment #2: rc2-fixes.patch --]
[-- Type: text/plain, Size: 923 bytes --]

diff -rNu old/drivers/scsi/in2000.c linux/drivers/scsi/in2000.c
--- old/drivers/scsi/in2000.c	2001-09-30 21:26:07.000000000 +0200
+++ linux/drivers/scsi/in2000.c	2002-11-04 14:18:58.000000000 +0100
@@ -1916,14 +1916,14 @@
    0
    };
 
-static const unsigned short base_tab[] in2000__INITDATA = {
+static unsigned short base_tab[] in2000__INITDATA = {
    0x220,
    0x200,
    0x110,
    0x100,
    };
 
-static const int int_tab[] in2000__INITDATA = {
+static int int_tab[] in2000__INITDATA = {
    15,
    14,
    11,
diff -rNu old/drivers/scsi/t128.c linux/drivers/scsi/t128.c
--- old/drivers/scsi/t128.c	2001-12-21 18:41:55.000000000 +0100
+++ kubux/drivers/scsi/t128.c	2002-11-04 14:21:47.000000000 +0100
@@ -142,7 +142,7 @@
 
 #define NO_BASES (sizeof (bases) / sizeof (struct base))
 
-static const struct signature {
+static struct signature {
 	const char *string;
 	int offset;
 } signatures[] __initdata = {
 

  reply	other threads:[~2002-11-15 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-15 15:10 Linux 2.4.20-rc2 Marcelo Tosatti
2002-11-15 19:19 ` Andreas Steinmetz [this message]
2002-11-15 23:04 ` Adrian Bunk
2002-11-16  7:16   ` Robert Read
2002-11-16  2:04 ` Keith Owens
2002-11-16 17:22 ` Adrian Bunk
2002-11-22  1:14 ` Linux 2.4.20-rc2 screwy ac97_codec.c:codec_id() Paul
2002-11-22  1:57   ` Alan Cox
2002-11-22  4:05     ` Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DD548AF.2000204@domdv.de \
    --to=ast@domdv.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox