From: Jeff Garzik <jgarzik@pobox.com>
To: Olaf Dietsche <olaf.dietsche#list.linux-kernel@t-online.de>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH] 2.5.47: strdup()
Date: Sat, 16 Nov 2002 01:25:38 -0500 [thread overview]
Message-ID: <3DD5E4E2.2020101@pobox.com> (raw)
In-Reply-To: <87d6p63ui2.fsf@goat.bogus.local>
Olaf Dietsche wrote:
> This *untested* patch adds strdup(). There are about five or six
> different strdup() implementations in various parts of the kernel.
>
> +#ifndef __HAVE_ARCH_STRDUP
> +/**
> + * strdup - allocate memory and duplicate a string
> + */
> +char *strdup(const char *s)
> +{
> + char *p = kmalloc(strlen(s) + 1, GFP_KERNEL);
> + if (p)
> + strcpy(p, s);
> +
> + return p;
> }
Comments:
* arch-specific strdup is unlikely
* IMO safer to create a strndup, and then update all strdup callers to
use strndup...
next prev parent reply other threads:[~2002-11-16 6:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-16 6:21 [PATCH] 2.5.47: strdup() Olaf Dietsche
2002-11-16 6:25 ` Jeff Garzik [this message]
2002-11-16 6:31 ` Andrew Morton
2002-11-16 15:42 ` Olaf Dietsche
2002-11-17 23:32 ` Werner Almesberger
2002-11-18 2:43 ` Olaf Dietsche
2002-11-16 6:41 ` William Lee Irwin III
2002-11-17 0:08 ` Chris Wedgwood
2002-11-17 1:37 ` Olaf Dietsche
2002-11-17 4:40 ` Chris Wedgwood
-- strict thread matches above, loose matches on Subject: below --
2002-11-16 8:48 Peter Kjellerstedt
2002-11-16 15:53 ` Olaf Dietsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD5E4E2.2020101@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf.dietsche#list.linux-kernel@t-online.de \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox