From: Jeff Garzik <jgarzik@pobox.com>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: ink@jurassic.park.msu.ru, linux-kernel@vger.kernel.org,
david.rusling@reo.mts.dec.com, davidm@cs.arizona.edu
Subject: Re: Patch: linux-2.5.47/arch/alpha/kernel/pci.c - do not directly set pci_dev.dma_mask where possible
Date: Sat, 16 Nov 2002 16:24:24 -0500 [thread overview]
Message-ID: <3DD6B788.20108@pobox.com> (raw)
In-Reply-To: <20021116063842.A20141@baldur.yggdrasil.com>
Adam J. Richter wrote:
> --- linux-2.5.47/arch/alpha/kernel/pci.c 2002-11-10 19:28:03.000000000
> -0800
> +++ linux/arch/alpha/kernel/pci.c 2002-11-16 05:54:00.000000000 -0800
> @@ -124,7 +124,7 @@
> unsigned int class = dev->class >> 8;
>
> if (class == PCI_CLASS_BRIDGE_ISA || class == PCI_CLASS_BRIDGE_ISA) {
> - dev->dma_mask = MAX_ISA_DMA_ADDRESS - 1;
> + pci_set_dma_mask(dev, MAX_ISA_DMA_ADDRESS - 1);
> isa_bridge = dev;
> }
> }
No; pci_set_dma_mask is too high-level for the above arch-specific code.
When dma_mask is moved this will need to get examined and fixed up in
another way.
Jeff
prev parent reply other threads:[~2002-11-16 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-16 14:38 Patch: linux-2.5.47/arch/alpha/kernel/pci.c - do not directly set pci_dev.dma_mask where possible Adam J. Richter
2002-11-16 21:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD6B788.20108@pobox.com \
--to=jgarzik@pobox.com \
--cc=adam@yggdrasil.com \
--cc=david.rusling@reo.mts.dec.com \
--cc=davidm@cs.arizona.edu \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox