Re: [patch] threading fix, tid-2.5.47-A3

[Ulrich Drepper <drepper@redhat.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ingo Molnar wrote:
> But i think you are one of
> the few peoples who are running an NPTL system (ie. with the new
> NPTL-glibc actually installed as the default system glibc) - is binary
> compatibility important to you for this specific case?

It's all encapsulated in the libpthread which is used.  No apps need to
be recompiled so it is OK to make this incompatible change.


> we could do that - although we cannot fail the CHILD_SETTID variant, and i
> wanted to keep it symmetric.

I cannot see any reasonable way out if any of the put_user calls fail?
Do you want the clone() call to fail if the parent's receiving address
is wrong?  You'd have to go and kill the child again since it's already
created.

Instead let the user initialize the memory location the clone call is
supposed to write in with zero.  if the value didn't change the
user-level code can detect the error and handle appropriately.  So,
ignore the put_user errors.  Maybe say so explicitly and add (void) in
front.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE91/2G2ijCOnn/RHQRAt34AKCrzkjdPfQ3D1VvEXPW5fwZxmCvWgCgmY0A
IYWZflwRcxusjo4fMPOx6jk=
=xjs0
-----END PGP SIGNATURE-----