From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Mielke <mark@mark.mielke.cc>
Cc: Andre Hedrick <andre@linux-ide.org>,
Arjan van de Ven <arjanv@redhat.com>,
David McIlwraith <quack@bigpond.net.au>,
linux-kernel@vger.kernel.org
Subject: Re: spinlocks, the GPL, and binary-only modules
Date: Thu, 21 Nov 2002 12:21:21 -0500 [thread overview]
Message-ID: <3DDD1611.9010003@pobox.com> (raw)
In-Reply-To: <1037875005.1863.0.camel@localhost.localdomain>
Mark Mielke wrote:
> On Thu, Nov 21, 2002 at 05:08:45AM -0800, Andre Hedrick wrote:
>
> >On 21 Nov 2002, Arjan van de Ven wrote:
> >
> >>It is if the AUTHOR then decides to distribute the resulting binary
> >>which would contain a mix of GPL and non GPL work..
> >
> >The mix is a direct result of developers knowingly inlining critical C
> >code into the headers. If this code was placed in proper .c files
> and not
> >set in a .h then the potential for accidental mixing is removed.
> >This would limit and restrict the headers to being structs and extern
> >functions to call.
>
>
> Some (not all) of the inlined functions are 'inline' to accelerate the
> kernel.
>
> Perhaps, though, the inlined functions should be declared:
>
> #ifdef __GNUC__
> # define INLINE extern inline
> #else
> # define INLINE inline
> #endif
[...]
Please review prior posts in this thread, notably from Andrew Morton and
Cort Dougan. They describe a much better method of doing this.
It still doesn't handle macros, though they are much less of a worry
since Linux kernel emphasizes inlines over macros.
Jeff
next prev parent reply other threads:[~2002-11-21 17:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 22:09 spinlocks, the GPL, and binary-only modules Jeff Garzik
2002-11-20 1:52 ` Rik van Riel
2002-11-20 2:48 ` Josh Myer
2002-11-20 2:59 ` Rik van Riel
2002-11-20 4:26 ` Ross Vandegrift
2002-11-20 6:41 ` archaios
2002-11-20 5:01 ` Andre Hedrick
2002-11-20 5:24 ` Jon Portnoy
2002-11-20 5:47 ` GPL rant -- was: " Zac Hansen
2002-11-20 14:21 ` Alan Cox
2002-11-20 18:57 ` Andre Hedrick
2002-11-20 19:09 ` Daniel Jacobowitz
2002-11-20 19:32 ` Andre Hedrick
2002-11-20 19:33 ` Alan Cox
2002-11-20 19:11 ` Andre Hedrick
2002-11-20 18:57 ` Thomas Langås
2002-11-20 19:15 ` Dana Lacoste
2002-11-20 18:32 ` nick
2002-11-20 19:50 ` Andre Hedrick
2002-11-20 19:16 ` nick
2002-11-21 2:25 ` Rik van Riel
2002-11-21 5:10 ` TAINTED (Re: spinlocks, the GPL, and binary-only modules) Andre Hedrick
2002-11-20 2:49 ` spinlocks, the GPL, and binary-only modules David McIlwraith
2002-11-20 3:06 ` Rik van Riel
2002-11-20 8:12 ` Mark Mielke
2002-11-20 10:17 ` Xavier Bestel
2002-11-20 14:19 ` Alan Cox
2002-11-20 14:09 ` Richard B. Johnson
2002-11-20 18:54 ` Andre Hedrick
2002-11-20 19:31 ` Cort Dougan
2002-11-20 19:40 ` Andre Hedrick
2002-11-20 19:44 ` Cort Dougan
2002-11-20 19:55 ` Andre Hedrick
2002-11-20 20:41 ` Jeff Garzik
2002-11-20 21:15 ` Alan Cox
2002-11-20 22:03 ` Andre Hedrick
2002-11-20 22:09 ` Rik van Riel
2002-11-20 22:15 ` Andre Hedrick
2002-11-20 22:43 ` Alan Cox
2002-11-20 22:17 ` Andre Hedrick
2002-11-20 22:36 ` Larry McVoy
2002-11-20 23:16 ` Eli Carter
2002-11-20 20:49 ` Alan Cox
2002-11-20 20:01 ` Andrew Morton
2002-11-20 20:05 ` Larry McVoy
2002-11-20 18:25 ` Andre Hedrick
2002-11-21 10:36 ` Arjan van de Ven
2002-11-21 13:08 ` Andre Hedrick
2002-11-21 17:02 ` Mark Mielke
2002-11-22 0:00 ` Andre Hedrick
2002-11-21 17:21 ` Jeff Garzik [this message]
2002-11-22 6:19 ` Mark Mielke
2002-11-20 4:12 ` Some like it HOT! (Re: spinlocks, the GPL, and binary-only modules) Andre Hedrick
2002-11-20 6:21 ` spinlocks, the GPL, and binary-only modules Andre Hedrick
2002-11-20 7:38 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2002-11-20 3:03 David McIlwraith
2002-11-20 6:31 Samium Gromoff
2002-11-20 8:27 ` Mark Mielke
2002-11-20 19:09 Nicholas Berry
[not found] <fa.fglehrv.95g32b@ifi.uio.no>
[not found] ` <fa.h7et98v.hjm1of@ifi.uio.no>
2002-11-21 0:03 ` Russ Allbery
[not found] <fa.ni4tkev.3ge008@ifi.uio.no>
[not found] ` <fa.onsrmsv.1g08thi@ifi.uio.no>
2002-11-21 9:05 ` Giacomo Catenazzi
2002-11-21 16:54 Herman Oosthuysen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DDD1611.9010003@pobox.com \
--to=jgarzik@pobox.com \
--cc=andre@linux-ide.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@mark.mielke.cc \
--cc=quack@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox