The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Adam Kropelin <akropel1@rochester.rr.com>,
	Neil Cafferkey <caffer@cs.ucc.ie>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Setting MAC address in ewrk3 driver
Date: Thu, 21 Nov 2002 19:02:32 -0500	[thread overview]
Message-ID: <3DDD7418.2010408@pobox.com> (raw)
In-Reply-To: <20021121195417.A18859@cuc.ucc.ie>

Alan Cox wrote:

> On Thu, 2002-11-21 at 23:39, Adam Kropelin wrote:
>
> >Alan, could you clarify for me? I'm the last guy to diddle with ewrk3 so
> >I'll track this down if there is indeed something to track down. ewrk3
> >has a private ioctl for setting the mac address. By the "up" method do
> >you mean the etherdev open method? Should there be a standard ioctl
> >implemented for setting the mac address?
>
>
> dev->set_mac_address()



To be more specific:

Read the MAC address in the probe phase.
Write MAC address to NIC on _each_ dev->open().
If you care about changing the MAC address while interface is up, 
implement dev->set_mac_address().

So, dev->set_mac_address() is pretty useless, when you can just tell 
users "down the interface before setting MAC address" which is a sane 
thing to do anyway, and much less complicated.

	Jeff




  parent reply	other threads:[~2002-11-21 23:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-21 19:54 Setting MAC address in ewrk3 driver Neil Cafferkey
2002-11-21 21:28 ` Alan Cox
2002-11-21 23:39   ` Adam Kropelin
2002-11-22  0:26     ` Alan Cox
2002-11-21 23:29 ` Adam Kropelin
2002-11-22  0:02 ` Jeff Garzik [this message]
2002-11-22  1:30   ` [PATCH] " Adam Kropelin
2002-11-26  1:47     ` Neil Cafferkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DDD7418.2010408@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akropel1@rochester.rr.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=caffer@cs.ucc.ie \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox