From: Brian Murphy <brian@murphy.dk>
To: linux-kernel@vger.kernel.org
Cc: joakim.tjernlund@lumentis.se
Subject: Re: [PATCH 2.5] crc32 static initialization
Date: Sat, 23 Nov 2002 18:52:04 +0100 [thread overview]
Message-ID: <3DDFC044.30701@murphy.dk> (raw)
In-Reply-To: IGEFJKJNHJDCBKALBJLLEEEEFIAA.joakim.tjernlund@lumentis.se
Joakim Tjernlund wrote:
>I have tested the new CRC32 patch on my big endian CPU(mpc860) in
>linux 2.4. Since the Makefiles look different in 2.4 vs. 2.5 I built and ran
>gen_crctable.c manually, so I can not comment on the Makefile changes.
>
>Also, testing this in 2.4 makes it hard to generate a new 2.5 patch, so
>I will just comment and send the whole file(se below)
>
>
Thanks for the testing.
>Found this:
>
> crc32.c in crc32_be(): crc32table_le should be crc32table_be
>
>
Can you send me a patch? I just used the original patch you sent me
which uses
crc32table_le in crc32_be.
>
> Finally, I think the new local crc32.h should be renamed to crc32defs.h to
> avoid confusion with the real linux/crc32.h.
>
>
Possibly, all h files contain "defs".
/Brian
next prev parent reply other threads:[~2002-11-23 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-22 10:03 [PATCH 2.5] crc32 static initialization Joakim Tjernlund
2002-11-22 20:25 ` Brian Murphy
2002-11-22 21:22 ` Joakim Tjernlund
2002-11-23 16:25 ` Joakim Tjernlund
2002-11-23 17:52 ` Brian Murphy [this message]
2002-11-23 23:19 ` Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2002-11-21 22:28 Brian Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DDFC044.30701@murphy.dk \
--to=brian@murphy.dk \
--cc=joakim.tjernlund@lumentis.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox