Re: [PATCH] POSIX message queues, 2.5.50

[Manfred Spraul <manfred@colorfullife.com>]

Some notes:
- coding style: linux functions usually have only one return at the end 
of the function, and goto internally. mqueue_parse_options() does that, 
mqueue_create contains multiple returns.
- why do you allocate the ext_wait_queue structure dynamically? Put it 
on the stack, that avoids error handling for failed allocations.
- reusing kernel functions is not a disadvantage - load_msg() and 
store_msg() automagically split the kmalloc allocations into page sized 
chunks.
- why do you use __add_wait_queue in wq_sleep_on()? It seems you have 
copied that code from kernel/sched.c - it's not needed. It was needed for

    cli()
    if(condition_var==0)
        sleep_on(&my_queue);

--
    Manfred