From: Andrew Morton <akpm@digeo.com>
To: Nick Piggin <piggin@cyberone.com.au>
Cc: lkml <linux-kernel@vger.kernel.org>,
"ext3-users@redhat.com" <ext3-users@redhat.com>
Subject: Re: data corrupting bug in 2.4.20 ext3, data=journal
Date: Sun, 01 Dec 2002 23:17:02 -0800 [thread overview]
Message-ID: <3DEB08EE.CBA49BA@digeo.com> (raw)
In-Reply-To: 3DEA0374.2040306@cyberone.com.au
Nick Piggin wrote:
>
> Andrew Morton wrote:
>
> >In 2.4.20-pre5 an optimisation was made to the ext3 fsync function
> >which can very easily cause file data corruption at unmount time. This
> >was first reported by Nick Piggin on November 29th (one day after 2.4.20 was
> >released, and three months after the bug was merged. Unfortunate timing)
> >
> In fact it was reported on lkml on 18th July IIRC before 2.4.19 was
> released if that is any help to you. 2.4.19 and 2.4.20 are affected
> and I haven't tested previous releases. I was going to re-report it
> sometime, but Alan brought it to light just the other day.
>
Are you sure? I can't make it happen on 2.4.19. And disabling the new
BH_Freed logic (which went into 2.4.20-pre5) makes it go away.
--- linux-akpm/fs/jbd/commit.c~a Sun Dec 1 23:10:12 2002
+++ linux-akpm-akpm/fs/jbd/commit.c Sun Dec 1 23:10:27 2002
@@ -695,7 +695,7 @@ skip_commit: /* The journal should be un
* use in a different page. */
if (__buffer_state(bh, Freed)) {
clear_bit(BH_Freed, &bh->b_state);
- clear_bit(BH_JBDDirty, &bh->b_state);
+// clear_bit(BH_JBDDirty, &bh->b_state);
}
if (buffer_jdirty(bh)) {
_
next prev parent reply other threads:[~2002-12-02 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-01 8:11 data corrupting bug in 2.4.20 ext3, data=journal Andrew Morton
2002-12-01 8:52 ` Andrew Morton
2002-12-01 12:41 ` Nick Piggin
2002-12-02 7:17 ` Andrew Morton [this message]
2002-12-02 12:15 ` Stephen C. Tweedie
2002-12-02 15:37 ` Stephen C. Tweedie
2002-12-02 17:45 ` Andrew Morton
2002-12-02 8:26 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DEB08EE.CBA49BA@digeo.com \
--to=akpm@digeo.com \
--cc=ext3-users@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox