[ide-scsi] "structure has no member named `tag'"

[ide-scsi] "structure has no member named `tag'"

[Joseph Pingenot]

Found this on 2.5.50+bk3

  gcc -Wp,-MD,drivers/scsi/.ide-scsi.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6 -Iarch/i386/mach-generic -nostdinc -iwithprefix include -DMODULE   -DKBUILD_BASENAME=ide_scsi -DKBUILD_MODNAME=ide_scsi   -c -o drivers/scsi/ide-scsi.o drivers/scsi/ide-scsi.c
drivers/scsi/ide-scsi.c: In function `should_transform':
drivers/scsi/ide-scsi.c:767: structure has no member named `tag'
make[2]: *** [drivers/scsi/ide-scsi.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2


-- 
Joseph===============================================trelane@digitasaru.net
"I use Linux and it makes me feel safer knowing exactly what security
 problems my boxen are facing. If I wanted filtered information or a public
 relations a** kissing, I'd use Microsoft products." --dattaway, on /.

Re: [ide-scsi] "structure has no member named `tag'"

[Rusty Lynch]

There was a discussion on this at
http://marc.theaimsgroup.com/?t=103861087100001&r=1&w=2

To get past this you can just change the line to compare ->name instead ->tag until the real fix lands.

    -rustyl
----- Original Message -----
From: "Joseph Pingenot" <trelane@digitasaru.net>
To: <linux-kernel@vger.kernel.org>
Sent: Tuesday, December 03, 2002 2:09 PM
Subject: [ide-scsi] "structure has no member named `tag'"


> Found this on 2.5.50+bk3
>
>


gcc -Wp,-MD,drivers/scsi/.ide-scsi.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno
-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=k6 -Iarch/i386/mach-generic -nostdinc -iwithprefix
include -DMODULE   -DKBUILD_BASENAME=ide_scsi -DKBUILD_MODNAME=ide_scsi   -c -o drivers/scsi/ide-scsi.o drivers/scsi/ide-scsi.c
> drivers/scsi/ide-scsi.c: In function `should_transform':
> drivers/scsi/ide-scsi.c:767: structure has no member named `tag'
> make[2]: *** [drivers/scsi/ide-scsi.o] Error 1
> make[1]: *** [drivers/scsi] Error 2
> make: *** [drivers] Error 2
>
>
> --
> Joseph===============================================trelane@digitasaru.net
> "I use Linux and it makes me feel safer knowing exactly what security
>  problems my boxen are facing. If I wanted filtered information or a public
>  relations a** kissing, I'd use Microsoft products." --dattaway, on /.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [ide-scsi] "structure has no member named `tag'"

[Mike Anderson]

Rusty Lynch [rusty@linux.co.intel.com] wrote:
> There was a discussion on this at
> http://marc.theaimsgroup.com/?t=103861087100001&r=1&w=2
> 
> To get past this you can just change the line to compare ->name instead ->tag until the real fix lands.

You can use this patch until the real one comes out.

-andmike
--
Michael Anderson
andmike@us.ibm.com

--- a/drivers/scsi/ide-scsi.c	2002-11-23 13:01:23.000000000 +1100
+++ b/drivers/scsi/ide-scsi.c	2002-12-01 00:44:26.000000000 +1100
@@ -764,7 +764,7 @@
 
 	if (disk) {
 		struct Scsi_Device_Template **p = disk->private_data;
-		if (strcmp((*p)->tag, "sg") == 0)
+		if (strcmp((*p)->scsi_driverfs_driver.name, "sg") == 0)
 			return test_bit(IDESCSI_SG_TRANSFORM, &scsi->transform);
 	}
 	return test_bit(IDESCSI_TRANSFORM, &scsi->transform);

Re: [ide-scsi] "structure has no member named `tag'"

[Douglas Gilbert]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

"Rusty Lynch" <rusty@linux.co.intel.com> wrote
 >
 > There was a discussion on this at
 > http://marc.theaimsgroup.com/?t=103861087100001&r=1&w=2
 >
 > To get past this you can just change the line to compare
 > ->name instead ->tag until the real fix lands.

For lk 2.5.50-bk3 that attached patch should work.

Doug Gilbert



[-- Attachment #2: ide-scsi_2550mike.diff --]
[-- Type: text/plain, Size: 458 bytes --]

--- linux/drivers/scsi/ide-scsi.c	2002-11-23 13:01:23.000000000 +1100
+++ linux/drivers/scsi/ide-scsi.c2550mike	2002-12-01 00:44:26.000000000 +1100
@@ -764,7 +764,7 @@
 
 	if (disk) {
 		struct Scsi_Device_Template **p = disk->private_data;
-		if (strcmp((*p)->tag, "sg") == 0)
+		if (strcmp((*p)->scsi_driverfs_driver.name, "sg") == 0)
 			return test_bit(IDESCSI_SG_TRANSFORM, &scsi->transform);
 	}
 	return test_bit(IDESCSI_TRANSFORM, &scsi->transform);