* [patch][trivial] include <asm-generic/topology.h>
@ 2002-12-05 0:03 Matthew Dobson
0 siblings, 0 replies; only message in thread
From: Matthew Dobson @ 2002-12-05 0:03 UTC (permalink / raw)
To: Linus Torvalds, Martin Bligh, Peter Rival, Anton Blanchard
Cc: Trivial Patch Monkey, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
Linus,
For a small bit of sanity and a savings of 9 lines of code, we should
be including the generic topology macros in the alpha & ppc64 topology
files, rather than just redefining them. It is much easier to keep all
the generic topology macros in sync this way, too.
Cheers!
-Matt
[mcd@arrakis patches]$ diffstat use_generic_topo-2.5.50.patch
asm-alpha/topology.h | 19 +++++++------------
asm-ppc64/topology.h | 8 ++------
2 files changed, 9 insertions(+), 18 deletions(-)
[-- Attachment #2: use_generic_topo-2.5.50.patch --]
[-- Type: text/plain, Size: 1879 bytes --]
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.50-vanilla/include/asm-alpha/topology.h linux-2.5.50-use_generic/include/asm-alpha/topology.h
--- linux-2.5.50-vanilla/include/asm-alpha/topology.h Wed Nov 27 14:35:53 2002
+++ linux-2.5.50-use_generic/include/asm-alpha/topology.h Wed Dec 4 15:57:38 2002
@@ -1,20 +1,15 @@
#ifndef _ASM_ALPHA_TOPOLOGY_H
#define _ASM_ALPHA_TOPOLOGY_H
-#ifdef CONFIG_NUMA
-#ifdef CONFIG_ALPHA_WILDFIRE
+#if defined(CONFIG_NUMA) && defined(CONFIG_ALPHA_WILDFIRE)
+
/* With wildfire assume 4 CPUs per node */
#define __cpu_to_node(cpu) ((cpu) >> 2)
-#endif /* CONFIG_ALPHA_WILDFIRE */
-#endif /* CONFIG_NUMA */
-#if !defined(CONFIG_NUMA) || !defined(CONFIG_ALPHA_WILDFIRE)
-#define __cpu_to_node(cpu) (0)
-#define __memblk_to_node(memblk) (0)
-#define __parent_node(nid) (0)
-#define __node_to_first_cpu(node) (0)
-#define __node_to_cpu_mask(node) (cpu_online_map)
-#define __node_to_memblk(node) (0)
-#endif /* !CONFIG_NUMA || !CONFIG_ALPHA_WILDFIRE */
+#else /* !CONFIG_NUMA || !CONFIG_ALPHA_WILDFIRE */
+
+#include <asm-generic/topology.h>
+
+#endif /* CONFIG_NUMA && CONFIG_ALPHA_WILDFIRE */
#endif /* _ASM_ALPHA_TOPOLOGY_H */
diff -Nur --exclude-from=/usr/src/.dontdiff linux-2.5.50-vanilla/include/asm-ppc64/topology.h linux-2.5.50-use_generic/include/asm-ppc64/topology.h
--- linux-2.5.50-vanilla/include/asm-ppc64/topology.h Wed Nov 27 14:36:22 2002
+++ linux-2.5.50-use_generic/include/asm-ppc64/topology.h Wed Dec 4 15:57:38 2002
@@ -48,12 +48,8 @@
#else /* !CONFIG_NUMA */
-#define __cpu_to_node(cpu) (0)
-#define __memblk_to_node(memblk) (0)
-#define __parent_node(nid) (0)
-#define __node_to_first_cpu(node) (0)
-#define __node_to_cpu_mask(node) (cpu_online_map)
-#define __node_to_memblk(node) (0)
+/* If non-NUMA, grab the generic macros */
+#include <asm-generic/topology.h>
#endif /* CONFIG_NUMA */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-12-05 0:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-05 0:03 [patch][trivial] include <asm-generic/topology.h> Matthew Dobson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).