[PATCH][2.5][Trivial] VIA Rhine Kconfig entry

[PATCH][2.5][Trivial] VIA Rhine Kconfig entry

[Roger Luethi]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Fix and update VIA Rhine description at least for 2.5 (I'll do 2.4, too, if
there's interest). Removed "experimental" flag for Rhine MMIO while I was
at it. Just barely resisted the temptation to make VIA Rhine conflict with
IO-APIC -- that seems to emerge as a fatal combo.

Please apply.

Roger

[-- Attachment #2: Kconfig-via-rhine.diff --]
[-- Type: text/plain, Size: 1441 bytes --]

--- linux-2.5.50/drivers/net/Kconfig.orig	Sun Dec  8 00:29:44 2002
+++ linux-2.5.50/drivers/net/Kconfig	Sun Dec  8 01:00:40 2002
@@ -1426,8 +1426,10 @@
 	tristate "VIA Rhine support"
 	depends on NET_PCI && PCI
 	help
-	  If you have a VIA "rhine" based network card (Rhine-I (3043) or
-	  Rhine-2 (VT86c100A)), say Y here.
+	  If you have a VIA "Rhine" based network card (Rhine-I (VT86C100A),
+	  Rhine-II (VT6102), or Rhine-III (VT6105)), say Y here. Rhine-type
+	  Ethernet functions can also be found integrated on South Bridges
+	  (e.g. VT8235).
 
 	  This driver is also available as a module ( = code which can be
 	  inserted in and removed from the running kernel whenever you want).
@@ -1436,15 +1438,15 @@
 	  well as <file:Documentation/networking/net-modules.txt>.
 
 config VIA_RHINE_MMIO
-	bool "Use MMIO instead of PIO (EXPERIMENTAL)"
-	depends on VIA_RHINE && EXPERIMENTAL
+	bool "Use MMIO instead of PIO"
+	depends on VIA_RHINE
 	help
 	  This instructs the driver to use PCI shared memory (MMIO) instead of
 	  programmed I/O ports (PIO). Enabling this gives an improvement in
 	  processing time in parts of the driver.
 
-	  It is not known if this works reliably on all "rhine" based cards,
-	  but it has been tested successfully on some DFE-530TX adapters.
+	  It is not known if this works reliably on all "Rhine" based cards,
+	  but it has been tested successfully on several adapters.
 
 	  If unsure, say N.
 

Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

[Jeff Garzik]

Roger Luethi wrote:
> at it. Just barely resisted the temptation to make VIA Rhine conflict with
> IO-APIC -- that seems to emerge as a fatal combo.


Patch looks ok to me, I'll queue it.

I agree about IO-APIC -- though I also think the reports that replacing 
via-rhine with linuxfet, and changing nothing else, helps the situation.

It might be something cosmetic like silly dev->tx_timeout handling, or 
it might be something useful like a chip-specific patch [often happens 
with on-mobo chips] or even a north/south-bridge-specific fixup.

	Jeff

Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

[Roger Luethi]

On Sat, 07 Dec 2002 22:15:42 -0500, Jeff Garzik wrote:
> I agree about IO-APIC -- though I also think the reports that replacing 
> via-rhine with linuxfet, and changing nothing else, helps the situation.
> 
> It might be something cosmetic like silly dev->tx_timeout handling, or 
> it might be something useful like a chip-specific patch [often happens 
> with on-mobo chips] or even a north/south-bridge-specific fixup.

There are two different kinds of Rhine problems that are reportedly fixed
by turning apic support off:

a) No link, card's dead in the water
b) Netdev watchdog triggered despite recent Tx abort fix

No telling whether the cause is the same for both cases. I don't have
sufficient data on mobos or chip sets involved and where linuxfet helps. As
I am currently short on APIC hardware myself, I'll focus on clean ups and
improved diagnostics for now.

Roger

Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

[Steve Brueggeman]

Is it possible that this may be related to this thread???

To: Linus Torvalds <torvalds@transmeta.com>
Subject: Re: /proc/pci deprecation?
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: 09 Dec 2002 14:11:07 +0000
Cc: Richard Henderson <rth@twiddle.net>,
	Patrick Mochel <mochel@osdl.org>,
	Willy Tarreau <willy@w.ods.org>,
	Petr Vandrovec <VANDROVE@vc.cvut.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	jgarzik@pobox.com

On Mon, 2002-12-09 at 01:54, Linus Torvalds wrote:
>  - we should _never_ update the PCI_INTERRUPT_LINE register, because it
>    destroys boot loader information (the same way we need to not overwrite
>    BIOS extended areas and ACPI areas etc in order to be able to reboot
>    cleanly)

I wonder if this is why we have all these problems with VIA chipset
interrupt handling. According to VIA docs they _do_ use
PCI_INTERRUPT_LINE on integrated devices to select the IRQ routing
between APIC and PCI/ISA etc, as well as 0 meaning "IRQ disabled"

Alan



On Tue, 10 Dec 2002 14:28:14 +0100, you wrote:

>On Sat, 07 Dec 2002 22:15:42 -0500, Jeff Garzik wrote:
>> I agree about IO-APIC -- though I also think the reports that replacing 
>> via-rhine with linuxfet, and changing nothing else, helps the situation.
>> 
>> It might be something cosmetic like silly dev->tx_timeout handling, or 
>> it might be something useful like a chip-specific patch [often happens 
>> with on-mobo chips] or even a north/south-bridge-specific fixup.
>
>There are two different kinds of Rhine problems that are reportedly fixed
>by turning apic support off:
>
>a) No link, card's dead in the water
>b) Netdev watchdog triggered despite recent Tx abort fix
>
>No telling whether the cause is the same for both cases. I don't have
>sufficient data on mobos or chip sets involved and where linuxfet helps. As
>I am currently short on APIC hardware myself, I'll focus on clean ups and
>improved diagnostics for now.
>
>Roger
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH][2.5][Trivial] VIA Rhine Kconfig entry

[Alan Cox]

On Tue, 2002-12-10 at 19:19, Steve Brueggeman wrote:
> Is it possible that this may be related to this thread???

I am sure it is