public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Aniruddha M Marathe <aniruddha.marathe@wipro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem with mm1 patch for 2.5.51
Date: Tue, 10 Dec 2002 21:08:54 -0800	[thread overview]
Message-ID: <3DF6C866.71597CD3@digeo.com> (raw)
In-Reply-To: 94F20261551DC141B6B559DC4910867201DE24@blr-m3-msg.wipro.com

Aniruddha M Marathe wrote:
> 
> Hi,
> I applied mm1 patch to kernel 2.5.51 and I ran LM bench to test its performance.
> Here are the errors that I obtained.
> 
> EXT3-fs error (device ide0(3,6)) in start_transaction: Journal has aborted

An off-by-one was gratuitously added to ext3_free_blocks


--- 25/fs/ext3/balloc.c~dud-patch	Tue Dec 10 21:07:20 2002
+++ 25-akpm/fs/ext3/balloc.c	Tue Dec 10 21:07:27 2002
@@ -122,7 +122,7 @@ void ext3_free_blocks (handle_t *handle,
 	es = EXT3_SB(sb)->s_es;
 	if (block < le32_to_cpu(es->s_first_data_block) ||
 	    block + count < block ||
-	    block + count >= le32_to_cpu(es->s_blocks_count)) {
+	    block + count > le32_to_cpu(es->s_blocks_count)) {
 		ext3_error (sb, "ext3_free_blocks",
 			    "Freeing blocks not in datazone - "
 			    "block = %lu, count = %lu", block, count);

  reply	other threads:[~2002-12-11  5:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-11  4:52 Problem with mm1 patch for 2.5.51 Aniruddha M Marathe
2002-12-11  5:08 ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-12-11  5:08 Con Kolivas
2002-12-11  5:38 ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DF6C866.71597CD3@digeo.com \
    --to=akpm@digeo.com \
    --cc=aniruddha.marathe@wipro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox