From: Andrew Morton <akpm@digeo.com>
To: Oleg Drokin <green@namesys.com>
Cc: Hans Reiser <reiser@namesys.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes
Date: Sat, 14 Dec 2002 10:42:38 -0800 [thread overview]
Message-ID: <3DFB7B9E.FC404B6B@digeo.com> (raw)
In-Reply-To: 20021214162108.A3452@namesys.com
Oleg Drokin wrote:
>
> Hello!
>
> On Fri, Dec 13, 2002 at 01:40:42PM -0800, Andrew Morton wrote:
>
> > This seems wrong. This could be a newly-allocated pagecache page. It is not
> > yet fully uptodate. If (say) the subsequent copy_from_user gets a fault then
> > it appears that this now-uptodate pagecache page will leak uninitialised stuff?
>
> Ok, after all I think we do not need this uptodate stuff at all.
Well that certainly simplifies things.
> Find below the patch that address all the issues you've brought.
> It is on top of previous one.
> Do you think it is ok now?
I addresses the things I noticed and raised, thanks. Except for the
stack-space use. People are waving around 4k-stack patches, and we
do need to be careful there.
next prev parent reply other threads:[~2002-12-14 18:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-13 18:56 [BK][PATCH] ReiserFS CPU and memory bandwidth efficient large writes Hans Reiser
2002-12-13 21:40 ` Andrew Morton
2002-12-14 1:11 ` Hans Reiser
2002-12-14 11:44 ` Oleg Drokin
2002-12-14 18:27 ` Andrew Morton
2002-12-14 13:21 ` Oleg Drokin
2002-12-14 18:42 ` Andrew Morton [this message]
2002-12-14 19:20 ` Oleg Drokin
2002-12-14 20:10 ` Andrew Morton
2002-12-14 20:25 ` Oleg Drokin
2002-12-16 18:24 ` Chris Mason
2002-12-17 10:53 ` Oleg Drokin
2002-12-14 22:21 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DFB7B9E.FC404B6B@digeo.com \
--to=akpm@digeo.com \
--cc=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox