linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: peter <pvant67@wnyip.net>
To: linux-kernel@vger.kernel.org, Keith Owens <kaos@ocs.com>,
	Michael E Chastain <mec@shout.net>,
	kbuild-devel@lists.sourceforge.net,
	Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH] fix for RPM build target under newer versions
Date: Tue, 17 Dec 2002 05:40:01 -0500	[thread overview]
Message-ID: <3DFEFF01.7040304@wnyip.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hi all,
	I notice there's an "rpm" target in the Makefile, which seems broken 
under RH 8.0. This may also apply to some "bleeding-edge" versions of 
Mandrake and Suse. Specifically, RH "split" the RPM build process into a 
separate utility from the old style rpm command. This could be fixed 
with a few aliases to keep backwards compatibility a bit easier. I 
wonder why an RH install doesn't already do this?

The reason why I'm sending this is because it's in the Makefile itself. 
If it wasn't for that, I'd just use the aliases mentioned above.

[-- Attachment #2: Makefile.patch --]
[-- Type: text/plain, Size: 697 bytes --]

--- /usr/src/linux-2.4.19/Makefile	2002-12-15 19:04:20.000000000 -0500
+++ /home/pete/Makefile.new	2002-12-17 04:36:49.000000000 -0500
@@ -567,5 +567,16 @@
 	rm $(KERNELPATH) ; \
 	cd $(TOPDIR) ; \
 	. scripts/mkversion > .version ; \
-	rpmbuild -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \
+
+#	RedHat split the RPM build process into a separate
+#	utility called "rpmbuild", leading to a broken 
+#	"make rpm" target in the kernel Makefile;
+#	this patch fixes that.
+
+	if [ `rpm --version | cut -b 12-15 | tr -d .` -ge '41' ] ;
+		then
+		rpmbuild -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \ 
+		else
+		rpm -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \
+	fi ; \
 	rm $(TOPDIR)/../$(KERNELPATH).tar.gz

             reply	other threads:[~2002-12-17 10:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-17 10:40 peter [this message]
2002-12-17 10:44 ` [PATCH] fix for RPM build target under newer versions Henning P. Schmiedehausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DFEFF01.7040304@wnyip.net \
    --to=pvant67@wnyip.net \
    --cc=kaos@ocs.com \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mec@shout.net \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).