public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Miles Lane <miles.lane@attbi.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.5.54 -- ohci-dbg.c: 358: In function `show_list': `data1' undeclared (first use in this function)
Date: Thu, 02 Jan 2003 07:24:08 -0800	[thread overview]
Message-ID: <3E145998.6020607@pacbell.net> (raw)
In-Reply-To: 1041487926.11532.83.camel@bellybutton.attbi.com

Miles Lane wrote:
>   gcc -Wp,-MD,drivers/usb/host/.ohci-hcd.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default -fomit-frame-pointer -nostdinc -iwithprefix include    -DKBUILD_BASENAME=ohci_hcd
> -DKBUILD_MODNAME=ohci_hcd   -c -o drivers/usb/host/ohci-hcd.o drivers/usb/host/ohci-hcd.c
> In file included from drivers/usb/host/ohci-hcd.c:137:
> drivers/usb/host/ohci-dbg.c: In function `show_list':
> drivers/usb/host/ohci-dbg.c:358: `data1' undeclared (first use in this function)
> drivers/usb/host/ohci-dbg.c:358: (Each undeclared identifier is reported only once
> drivers/usb/host/ohci-dbg.c:358: for each function it appears in.)
> drivers/usb/host/ohci-dbg.c:358: `data0' undeclared (first use in this function)
> make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1

Looks like Greg's patch to use more dev_*() debug macros changed
some conditional structures too ... so the sysfs debug files are
always compiled in, rather than only with CONFIG_USB_DEBUG which
is what defines them.

Workaround by enabling USB debugging in your configuration.

I'll send some patch around later, likely to just revert that
part of his patch since I actually like having "production"
OHCI modules be less than 12K.  Though maybe those files should
be enabled with some other Kconfig option.  Thoughts?

- Dave





  reply	other threads:[~2003-01-02 15:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-02  6:12 2.5.54 -- ohci-dbg.c: 358: In function `show_list': `data1' undeclared (first use in this function) Miles Lane
2003-01-02 15:24 ` David Brownell [this message]
2003-01-03  0:39   ` David Brownell
2003-01-03  4:44     ` Greg KH
2003-01-03  6:07       ` [linux-usb-devel] " David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E145998.6020607@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@attbi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox