From: David Brownell <david-b@pacbell.net>
To: Greg KH <greg@kroah.com>
Cc: Miles Lane <miles.lane@attbi.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>,
usb devel <linux-usb-devel@lists.sourceforge.net>
Subject: Re: [linux-usb-devel] Re: 2.5.54 -- ohci-dbg.c: 358: In function `show_list': `data1' undeclared (first use in this function)
Date: Thu, 02 Jan 2003 22:07:29 -0800 [thread overview]
Message-ID: <3E1528A1.5030302@pacbell.net> (raw)
In-Reply-To: 20030102204444.A2549@kroah.com
Greg KH wrote:
> On Thu, Jan 02, 2003 at 04:39:57PM -0800, David Brownell wrote:
>
>>+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,32)
>>+# define DRIVERFS_DEBUG_FILES
>>+#endif
>
>
> No, this is wrong, don't put this dependant on a specific kernel
> version that is long gone, that's why I took this portion out.
Actually it originally there to support a backport of that version
to the 2.4 kernel, which has periodically worked. That was the
downside of that particular patch of yours ... it didn't wrap the
dev_* calls as ohci_* calls, so the backport effort went up.
But OK, I'll remove that for now and resend.
- Dave
prev parent reply other threads:[~2003-01-03 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-02 6:12 2.5.54 -- ohci-dbg.c: 358: In function `show_list': `data1' undeclared (first use in this function) Miles Lane
2003-01-02 15:24 ` David Brownell
2003-01-03 0:39 ` David Brownell
2003-01-03 4:44 ` Greg KH
2003-01-03 6:07 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E1528A1.5030302@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=miles.lane@attbi.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox