From: Jeff Garzik <jgarzik@pobox.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: viro@math.psu.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5 INITRD + DEVFS crash
Date: Fri, 03 Jan 2003 23:25:24 -0500 [thread overview]
Message-ID: <3E166234.1040508@pobox.com> (raw)
In-Reply-To: <20030104041219.GA3066@gondor.apana.org.au>
Herbert Xu wrote:
> INITRD loading fails when DEVFS is enabled in the kernel as initrd_release
> calls del_gendisk which tries to free DEVFS partitions even though the
> create partitions function was never called.
[...]
> --- fs/partitions/check.c 3 Jan 2003 01:36:55 -0000 1.1.1.3
> +++ fs/partitions/check.c 4 Jan 2003 04:04:05 -0000
> @@ -522,7 +522,8 @@
> disk->io_ticks = 0;
> disk->time_in_queue = 0;
> disk->stamp = disk->stamp_idle = 0;
> - devfs_remove_partitions(disk);
> + if (disk->minors != 1)
> + devfs_remove_partitions(disk);
> if (disk->driverfs_dev) {
> sysfs_remove_link(&disk->kobj, "device");
> sysfs_remove_link(&disk->driverfs_dev->kobj, "block");
hmmmm. I'm not disputing the problem, but your solution sorta says to
me that there is a reference counting problem elsewhere. [disclaimer:
random guess] Maybe the initrd+devfs needs an additional reference
increment somewhere?
prev parent reply other threads:[~2003-01-04 4:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-04 4:12 [PATCH] 2.5 INITRD + DEVFS crash Herbert Xu
2003-01-04 4:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E166234.1040508@pobox.com \
--to=jgarzik@pobox.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox