public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Dominik Brodowski <linux@brodo.de>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	cpufreq@www.linux.org.uk
Subject: Re: [PATCH 2.5.54] cpufreq: update timer notifier
Date: Mon, 06 Jan 2003 13:34:31 -0800	[thread overview]
Message-ID: <3E19F667.30043A97@digeo.com> (raw)
In-Reply-To: 20030106135521.GC1307@brodo.de

Dominik Brodowski wrote:
> 
> +#else
> +#define adjust_jiffies(...)
> +#endif

This will fail to compile on gcc-2.91.66.  It's OK on 2.95.3.

sparc64 requires a compiler of similar vintage (2.92.11), so
I am trying to keep 2.91.66-on-x86 limping along so that breakage
can be detected more easily.

Please use

	#define adjust_jiffies(x...) do {} while (0)

here.   Or an empty inline, which tends to be nicer, because you
still get argument type checking.

  reply	other threads:[~2003-01-06 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-06 13:55 [PATCH 2.5.54] cpufreq: update timer notifier Dominik Brodowski
2003-01-06 21:34 ` Andrew Morton [this message]
2003-01-06 22:34   ` [PATCH] cpufreq: make gcc-2.91.66 happy (Was: Re: [PATCH 2.5.54] cpufreq: update timer notifier) Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E19F667.30043A97@digeo.com \
    --to=akpm@digeo.com \
    --cc=cpufreq@www.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox