From: Corey Minyard <minyard@acm.org>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PATCH: IPMI driver
Date: Thu, 09 Jan 2003 13:37:48 -0600 [thread overview]
Message-ID: <3E1DCF8C.8060408@acm.org> (raw)
In-Reply-To: 20030109192022.GA5693@codemonkey.org.uk
Dave Jones wrote:
>On Thu, Jan 09, 2003 at 01:16:29PM -0600, Corey Minyard wrote:
>
> > >Pull the 2.5 port from openipmi.sourceforge.net saves you doing the port
> > >yourself.
> > >
> > Definately pull the 2.5 port from there, as there are some differences
> > between the 2.4 and 2.5 versions.
>
>I had a quick skim through the patch.
>Is the handling of jiffies wraps done correctly ? It doesn't
>look like it...
>
>time_diff = ((jiffies_now - kcs_info->last_timeout_jiffies)
>
> Dave
>
I don't understand why that wouldn't work. Those are both unsigned long
values. Assuming twos complement, the time difference could be correct,
even in a wraparound case (unless a very large number of jiffies has
transpired, but that will never be the case here).
Am I missing something here?
-Corey
next prev parent reply other threads:[~2003-01-09 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200301090332.h093WML05981@hera.kernel.org>
2003-01-09 16:44 ` [PATCH] PATCH: IPMI driver Dave Jones
2003-01-09 18:06 ` Alan Cox
2003-01-09 17:22 ` Dave Jones
2003-01-09 18:12 ` Alan Cox
2003-01-09 19:16 ` Corey Minyard
2003-01-09 19:20 ` Dave Jones
2003-01-09 19:37 ` Corey Minyard [this message]
2003-01-09 20:17 ` Alan Cox
2003-01-09 19:37 ` Dave Jones
2003-01-09 20:42 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E1DCF8C.8060408@acm.org \
--to=minyard@acm.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox