Re: any chance of 2.6.0-test*?

Oliver Neukum
2003-01-12T20:24:40Z

> But in this case, the condition was already there.. My point is that if
> you don't need a goto, you shouldn't use it. Whenever there's an
> obvious way not to use it, don't.

You should not code to avoid a construction that's valid C.
Just use the control structure that comes natural.
Of course "if (c % 2) goto a;" is a crime, but things
like "if (!buffer) goto err_out_nomem;" are better because
the tell you why the code jumps here, it includes an implicit
comment.
if (buffer) {
/* do stuff */
} else {
return -ENOMEM;
}
just obscures the logic of the code.
Or look at it another way, if you dislike goto you should
crusade against conditional return as well.

Regards
Oliver