Re: any chance of 2.6.0-test*?

Rik van Riel
2003-01-12T21:32:23Z

On Sun, 12 Jan 2003, Rob Wilkens wrote:
> On Sun, 2003-01-12 at 16:15, Matti Aarnio wrote:

> > At first, read Documentation/CodingStyle of the kernel.
> > Then have a look into:
> >
> > fs/open.c file do_sys_truncate() function.

> - if (S_ISDIR(inode->i_mode))
> - goto dput_and_out;
> + if (S_ISDIR(inode->i_mode)){
> + path_release(&nd);
> + return error;
> + }

[snip same change in a few more changes]

OK, now imagine the dcache locking changing a little bit.
You need to update this piece of (duplicated) code in half
a dozen places in just this function and no doubt in dozens
of other places all over fs/*.c.

>From a maintenance point of view, a goto to a single block
of error handling code is easier to maintain.

regards,

Rik
--
Bravely reimplemented by the knights who say "NIH".
http://www.surriel.com/ http://guru.conectiva.com/
Current spamtrap: october@surriel.com