From: ryan <ryan@ryanflynn.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.56 sound/oss/sb_mixer.c bounds check
Date: Tue, 14 Jan 2003 23:21:06 -0500 [thread overview]
Message-ID: <3E24E1B2.3050308@ryanflynn.com> (raw)
In-Reply-To: <200301141930.00567.akpm@digeo.com>
> Yup.
>
> It would be better to do:
>
> if (dev < 0 || dev >= ARRAY_SIZE(smw_mix_regs))
yup, much better. i did a little housecleaning on the whole file, as
well as 2 more bounds checks in appropriate places.
i'm sorry to ask, but i'm new -- i've got a ~500 line patch, and my
email client is wrapping at 80 chars (unfortunately some lines run over
80 chars), is sending an attachment in ascii format ok? i've seen some
patches sent as attachments, not sure.
waiting for a yes/no response, please cc me
next prev parent reply other threads:[~2003-01-15 4:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 3:13 [PATCH] 2.5.56 sound/oss/sb_mixer.c bounds check ryan
2003-01-15 3:30 ` Andrew Morton
2003-01-15 4:21 ` ryan [this message]
2003-01-15 4:36 ` Andrew Morton
2003-01-15 5:34 ` (OT) " Bruce Harada
2003-01-15 6:44 ` Andrew Morton
2003-01-15 4:37 ` ryan
-- strict thread matches above, loose matches on Subject: below --
2003-01-15 5:05 Perez-Gonzalez, Inaky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E24E1B2.3050308@ryanflynn.com \
--to=ryan@ryanflynn.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox