Re: [PATCH] Re: [BUG] cardbus/hotplugging still broken in 2.5.56

jens.taprogge
2003-01-15T20:25:31Z

I am not sure if you have seen the patch I posted on l-k. It should fix
both issues.

Jens

On Wed, Jan 15, 2003 at 10:13:39PM +0200, Yaacov Akiba Slama wrote:
> Jens Taprogge wrote :
>
> >You are not freeing the possibly already allocated resources in case of
> >a failure of either pci_assign_resource() or pca_enable_device(). In
> >fact you are not even checking if pci_assign_resource() fails. That
> >seems wrong to me.
>
> There are two separate issues :
> 1) Fix the "ressource collisions" problem (and irq not known).
> 2) Freeing ressources in case of failure of some functions.
>
> My patch solves the first issue only in order to make cardbus with rom work.
> The point 2 is a janitor work.
>
> Thanks,
> Yaacov Akiba Slama

--
Jens Taprogge