public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yaacov Akiba Slama <ya@slamail.org>
To: linux-kernel@vger.kernel.org,
	Jens Taprogge <taprogge@idg.rwth-aachen.de>
Subject: Re: [PATCH] Re: [BUG] cardbus/hotplugging still broken in 2.5.56
Date: Wed, 15 Jan 2003 22:13:39 +0200	[thread overview]
Message-ID: <3E25C0F3.9000208@slamail.org> (raw)

Jens Taprogge wrote :

>You are not freeing the possibly already allocated resources in case of
>a failure of either pci_assign_resource() or pca_enable_device(). In
>fact you are not even checking if pci_assign_resource() fails. That
>seems wrong to me.

There are two separate issues :
1) Fix the "ressource collisions" problem (and irq not known).
2) Freeing ressources in case of failure of some functions.

My patch solves the first issue only in order to make cardbus with rom work.
The point 2 is a janitor work.

Thanks,
Yaacov Akiba Slama



             reply	other threads:[~2003-01-15 20:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-15 20:13 Yaacov Akiba Slama [this message]
2003-01-15 20:31 ` [PATCH] Re: [BUG] cardbus/hotplugging still broken in 2.5.56 jens.taprogge
2003-01-15 20:55   ` Yaacov Akiba Slama
  -- strict thread matches above, loose matches on Subject: below --
2003-01-15  8:11 Jens Taprogge
2003-01-15  9:13 ` Mikael Pettersson
2003-01-15 16:26   ` [PATCH] " Yaacov Akiba Slama
2003-01-15 19:47     ` Jens Taprogge
2003-01-15 20:23       ` Dave Jones
2003-01-14 18:39 [PATCH] Re : " Yaacov Akiba Slama

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E25C0F3.9000208@slamail.org \
    --to=ya@slamail.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=taprogge@idg.rwth-aachen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox